Sign upLogin

bcdice/BCDice

View on GitHub
Star
lib/bcdice/game_system/ParasiteBlood.rb

Summary

Maintainability
C
1 day
Test Coverage
B
88%

Method get_pb_aas_urge_table has 65 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def get_pb_aas_urge_table
        return [[
          # **第１段階
          '『緊急停止/20』機能異常の警報と共に、機能が緊急停止。次のターンのターン終了時まで［行動不能］となる。',
          '『動作不調/10』駆動系に異常発生。このターンのターン終了まで［行動不能］となる。',
Severity: Major
Found in lib/bcdice/game_system/ParasiteBlood.rb - About 2 hrs to fix

    Method get_pb_normal_urge_table has 65 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def get_pb_normal_urge_table
        return [[
          '『怒り/20』突然強い怒りに駆られる。最も近い対象を罵倒し、そのターンの終了まで[行動不能]となる。',
          '『暗闇/20』視神経に悪影響が出て、24時間[暗闇]になる。',
          '『悲哀/10』突然の悲みに動きが止まる。そのターンの終了まで[行動不能]となる。',
    Severity: Major
    Found in lib/bcdice/game_system/ParasiteBlood.rb - About 2 hrs to fix

      Method get_urge has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def get_urge(string) # パラサイトブラッドの衝動表
        unless /(\w*)URGE\s*(\d+)/i =~ string
          return '1'
        end
      Severity: Minor
      Found in lib/bcdice/game_system/ParasiteBlood.rb - About 1 hr to fix

        Method get_urge has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

              def get_urge(string) # パラサイトブラッドの衝動表
        unless /(\w*)URGE\s*(\d+)/i =~ string
          return '1'
        end
        Severity: Minor
        Found in lib/bcdice/game_system/ParasiteBlood.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              def get_pb_aas_urge_table
        return [[
          # **第１段階
          '『緊急停止/20』機能異常の警報と共に、機能が緊急停止。次のターンのターン終了時まで［行動不能］となる。',
          '『動作不調/10』駆動系に異常発生。このターンのターン終了まで［行動不能］となる。',
        Severity: Major
        Found in lib/bcdice/game_system/ParasiteBlood.rb and 1 other location - About 1 hr to fix
        lib/bcdice/game_system/ParasiteBlood.rb on lines 84..149

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 64.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              def get_pb_normal_urge_table
        return [[
          '『怒り/20』突然強い怒りに駆られる。最も近い対象を罵倒し、そのターンの終了まで[行動不能]となる。',
          '『暗闇/20』視神経に悪影響が出て、24時間[暗闇]になる。',
          '『悲哀/10』突然の悲みに動きが止まる。そのターンの終了まで[行動不能]となる。',
        Severity: Major
        Found in lib/bcdice/game_system/ParasiteBlood.rb and 1 other location - About 1 hr to fix
        lib/bcdice/game_system/ParasiteBlood.rb on lines 153..227

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 64.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status