Sign upLogin

bcdice/BCDice

View on GitHub
Star
lib/bcdice/game_system/PastFutureParadox.rb

Summary

Maintainability
F
4 days
Test Coverage

File PastFutureParadox.rb has 1188 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module BCDice
  module GameSystem
    class PastFutureParadox < Base
      # ゲームシステムの識別子
      ID = "PastFutureParadox"
Severity: Major
Found in lib/bcdice/game_system/PastFutureParadox.rb - About 3 days to fix

    Method action_roll has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def action_roll(command)
        parser = Command::Parser.new("PP", round_type: round_type)
                                .restrict_cmp_op_to(:>=, nil)
                                .enable_critical
                                .enable_fumble
    Severity: Minor
    Found in lib/bcdice/game_system/PastFutureParadox.rb - About 1 hr to fix

      Method get_table_index has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def get_table_index(table, operator, value, dice_count, dice_type)
        index = 0
        modify = 0
        dice_list = nil
        result = []
      Severity: Minor
      Found in lib/bcdice/game_system/PastFutureParadox.rb - About 1 hr to fix

        Method get_table_minus_index has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def get_table_minus_index(table, operator, value)
        index = 7
        modify = 0
        dice_list = nil
        result = []
        Severity: Minor
        Found in lib/bcdice/game_system/PastFutureParadox.rb - About 1 hr to fix

          Method action_roll has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

                def action_roll(command)
        parser = Command::Parser.new("PP", round_type: round_type)
                                .restrict_cmp_op_to(:>=, nil)
                                .enable_critical
                                .enable_fumble
          Severity: Minor
          Found in lib/bcdice/game_system/PastFutureParadox.rb - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method get_table_index has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                def get_table_index(table, operator, value, dice_count, dice_type)
          Severity: Minor
          Found in lib/bcdice/game_system/PastFutureParadox.rb - About 35 mins to fix

            Method get_table_index has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                  def get_table_index(table, operator, value, dice_count, dice_type)
        index = 0
        modify = 0
        dice_list = nil
        result = []
            Severity: Minor
            Found in lib/bcdice/game_system/PastFutureParadox.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method get_table_minus_index has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                  def get_table_minus_index(table, operator, value)
        index = 7
        modify = 0
        dice_list = nil
        result = []
            Severity: Minor
            Found in lib/bcdice/game_system/PastFutureParadox.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                  RTT = DiceTable::SaiFicSkillTable.new(
        [
          ['科学', ['人工知能', '計算機', '電子工学', '機械工学', '物理学', '数学', '天文学', '地学', '化学', '医療', 'バイオ技術']],
          ['知識', ['帝王学', '経済', '政治', '社会', '法律', '情報', '労働', '教育', '歴史', '語学', '文学']],
          ['身体', ['狙う', '斬る', '殴る', '跳ぶ', '走る', '避ける', '柔軟', '持ち上げる', '食べる', '飲む', '叫ぶ']],
            Severity: Major
            Found in lib/bcdice/game_system/PastFutureParadox.rb and 2 other locations - About 2 hrs to fix
            lib/bcdice/game_system/BloodCrusade.rb on lines 64..73
            lib/bcdice/game_system/ShinobiGami.rb on lines 106..117

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 94.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  TABLES_MOD_1D = {
        'RT' => DiceTable::Table.new(
          '帰還演出表',
          '1D6',
          [
            Severity: Major
            Found in lib/bcdice/game_system/PastFutureParadox.rb and 1 other location - About 1 hr to fix
            lib/bcdice/game_system/AlchemiaStruggle.rb on lines 138..197

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 66.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                      if dice_total <= cmd.fumble
            Result.fumble("ファンブル(判定失敗。改変度を1D6点増加してバタフライエフェクト発生)")
          elsif dice_total >= cmd.critical
            Result.critical("スペシャル(判定成功。疲労度を1D6点減少してバタフライエフェクト発生)")
          elsif cmd.cmp_op.nil?
            Severity: Minor
            Found in lib/bcdice/game_system/PastFutureParadox.rb and 1 other location - About 30 mins to fix
            lib/bcdice/game_system/SRS.rb on lines 282..292

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 33.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    sequence = [
          "(#{cmd.to_s(:after_modify_number)})",
          "#{dice_total}[#{dice_list.join(',')}]#{Format.modifier(cmd.modify_number)}",
          total,
          result.text
            Severity: Minor
            Found in lib/bcdice/game_system/PastFutureParadox.rb and 1 other location - About 15 mins to fix
            lib/bcdice/game_system/StarryDolls.rb on lines 131..136

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 26.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status