Sign upLogin

bcdice/BCDice

View on GitHub
Star
lib/bcdice/game_system/Postman.rb

Summary

Maintainability
B
6 hrs
Test Coverage
A
100%

Method checkRoll has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

      def checkRoll(diceCount, modify, type, target)
        diceArray = @randomizer.roll_barabara(diceCount, 6).sort
        dice = diceArray.sum()
        diceText = diceArray.join(",")
Severity: Minor
Found in lib/bcdice/game_system/Postman.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method checkRoll has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def checkRoll(diceCount, modify, type, target)
        diceArray = @randomizer.roll_barabara(diceCount, 6).sort
        dice = diceArray.sum()
        diceText = diceArray.join(",")
Severity: Minor
Found in lib/bcdice/game_system/Postman.rb - About 1 hr to fix

    Method get_weather_table has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def get_weather_table(roc)
        name = "天候チェック"
        table = [
          [2, '大雨と強風。探索判定の難易度に+4。'],
          [3, '風が強い1日になりそう。探索判定の難易度に+2。'],
    Severity: Minor
    Found in lib/bcdice/game_system/Postman.rb - About 1 hr to fix

      Method eval_game_system_specific_command has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def eval_game_system_specific_command(command)
        text =
          case command.upcase

          when /(\d+)?PO(\d+)?(([+-]\d+)*)?((>|>=|@)(\d+)(([+-]\d+)*)?)?/i
      Severity: Minor
      Found in lib/bcdice/game_system/Postman.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method get_weather_table has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def get_weather_table(roc)
        name = "天候チェック"
        table = [
          [2, '大雨と強風。探索判定の難易度に+4。'],
          [3, '風が強い1日になりそう。探索判定の難易度に+2。'],
      Severity: Minor
      Found in lib/bcdice/game_system/Postman.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

              table = [
          [2, '何をするでもなく、霞がかったような夜空を見上げる。ふと隣に目を向ければ、彼/彼女が居た。彼/彼女は、こうなる前の夜空を知っているのだろうか。'],
          [3, '夢を見た。大戦の最中、街が、人が、世界が焼けていく悪夢を。追い立てられるようにして目を覚ますと、彼/彼女が君を見ていた。　……もしかして、自分はよほどうなされていたのだろうか。'],
          [4, '周囲で見つけたガラクタを使って、ちょっとしたビックリ玩具を作ってみた。「彼/ 彼女」にコイツをけしかけたら、どんな反応をするだろうか？'],
          [5, '使えそうなものがないか探していると、カタンと物音がして何かが落ちた。拾い上げてみたそれは、かつてここで生活していた誰かの名残（写真、家具、玩具等）だった。'],
      Severity: Minor
      Found in lib/bcdice/game_system/Postman.rb and 2 other locations - About 35 mins to fix
      lib/bcdice/game_system/Postman.rb on lines 131..143
      lib/bcdice/game_system/meikyu_kingdom/item_table.rb on lines 284..296

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 35.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

              table = [
          [2, '大雨と強風。探索判定の難易度に+4。'],
          [3, '風が強い1日になりそう。探索判定の難易度に+2。'],
          [4, '晴れ。特になし。'],
          [5, '夜の間の雨でぬかるむ。探索判定の難易度に+2。'],
      Severity: Minor
      Found in lib/bcdice/game_system/Postman.rb and 2 other locations - About 35 mins to fix
      lib/bcdice/game_system/Postman.rb on lines 163..175
      lib/bcdice/game_system/meikyu_kingdom/item_table.rb on lines 284..296

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 35.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status