lib/bcdice/game_system/PulpCthulhu.rb from bcdice/BCDice

Avoid too many `return` statements within this method.
Open

          return nil

Found in lib/bcdice/game_system/PulpCthulhu.rb - About 30 mins to fix

Avoid too many `return` statements within this method.
Open

          return roll_1d20_table("狂気のタレント表", INSANE_TALENTS_TABLE)

Found in lib/bcdice/game_system/PulpCthulhu.rb - About 30 mins to fix

Avoid too many `return` statements within this method.
Open

          return roll_1d100_table("マニア表", MANIAS_TABLE)

Found in lib/bcdice/game_system/PulpCthulhu.rb - About 30 mins to fix

Avoid too many `return` statements within this method.
Open

          return roll_bms_table()

Found in lib/bcdice/game_system/PulpCthulhu.rb - About 30 mins to fix

Avoid too many `return` statements within this method.
Open

          return roll_1d20_table("キャスティング・ロール失敗表", FAILED_CASTING_EFFECTS_TABLE)

Found in lib/bcdice/game_system/PulpCthulhu.rb - About 30 mins to fix

Avoid too many `return` statements within this method.
Open

          return roll_1d100_table("恐怖症表", PHOBIAS_TABLE)

Found in lib/bcdice/game_system/PulpCthulhu.rb - About 30 mins to fix

Similar blocks of code found in 4 locations. Consider refactoring.
Open

      def roll_bmr_table()
        total_n = @randomizer.roll_once(10)
        text = MADNESS_REAL_TIME_TABLE[total_n - 1]

        time_n = @randomizer.roll_once(10)

Found in lib/bcdice/game_system/PulpCthulhu.rb and 3 other locations - About 20 mins to fix

Read up
Read up

lib/bcdice/game_system/Cthulhu7th.rb on lines 274..280

lib/bcdice/game_system/Cthulhu7th.rb on lines 297..303

lib/bcdice/game_system/PulpCthulhu.rb on lines 113..119

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

bcdice/BCDice

Summary

Maintainability

Test Coverage

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Similar blocks of code found in 4 locations. Consider refactoring.
Open

Duplicated Code

Tuning

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

Duplicated Code

Tuning

Refactorings

Further Reading

There are no issues that match your filters.

Category

Status

bcdice/BCDice

Summary

Maintainability

Test Coverage

Avoid too many return statements within this method. Open

Avoid too many return statements within this method. Open

Avoid too many return statements within this method. Open

Avoid too many return statements within this method. Open

Avoid too many return statements within this method. Open

Avoid too many return statements within this method. Open

Similar blocks of code found in 4 locations. Consider refactoring. Open

Duplicated Code

Tuning

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring. Open

Duplicated Code

Tuning

Refactorings

Further Reading

There are no issues that match your filters.

Category

Status

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Similar blocks of code found in 4 locations. Consider refactoring.
Open

Similar blocks of code found in 4 locations. Consider refactoring.
Open