Sign upLogin

bcdice/BCDice

View on GitHub
Star
lib/bcdice/game_system/RuinBreakers.rb

Summary

Maintainability
C
1 day
Test Coverage
A
95%

File RuinBreakers.rb has 258 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'bcdice/arithmetic_evaluator'
require 'bcdice/dice_table/table'
require 'bcdice/dice_table/range_table'

module BCDice
Severity: Minor
Found in lib/bcdice/game_system/RuinBreakers.rb - About 2 hrs to fix

    Method check_roll has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def check_roll(command)
        m = %r{^RB(-?\d+([+\-*/]\d+)*)(@(\d+))?(#(\d+))?$}.match(command)
        unless m
          return nil
        end
    Severity: Minor
    Found in lib/bcdice/game_system/RuinBreakers.rb - About 1 hr to fix

      Method check_roll has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

            def check_roll(command)
        m = %r{^RB(-?\d+([+\-*/]\d+)*)(@(\d+))?(#(\d+))?$}.match(command)
        unless m
          return nil
        end
      Severity: Minor
      Found in lib/bcdice/game_system/RuinBreakers.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

              "PE" => DiceTable::RangeTable.new(
          "ポジティブ感情表",
          "1D100",
          [
            [1..5, "【希望】相手はまるで自分の過去、あるいは未来を見ているように感じる。"],
      Severity: Major
      Found in lib/bcdice/game_system/RuinBreakers.rb and 2 other locations - About 1 hr to fix
      lib/bcdice/game_system/RuinBreakers.rb on lines 177..202
      lib/bcdice/game_system/RuinBreakers.rb on lines 232..257

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

              "RDF" => DiceTable::RangeTable.new(
          "破滅のイヤな感じ表",
          "1D100",
          [
            [1..5, "【水中で拘束】\n演出：水中で長い髪の毛が全身に絡みついて動きが重くなるような感覚。\nルーインブレイク成功：重い拘束から解き放たれたような快感。"],
      Severity: Major
      Found in lib/bcdice/game_system/RuinBreakers.rb and 2 other locations - About 1 hr to fix
      lib/bcdice/game_system/RuinBreakers.rb on lines 150..175
      lib/bcdice/game_system/RuinBreakers.rb on lines 177..202

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

              "NE" => DiceTable::RangeTable.new(
          "ネガティブ感情表",
          "1D100",
          [
            [1..5, "【同族嫌悪】1日に自分の忌むべき過去、あるいは自分自身を見ているように感じる。"],
      Severity: Major
      Found in lib/bcdice/game_system/RuinBreakers.rb and 2 other locations - About 1 hr to fix
      lib/bcdice/game_system/RuinBreakers.rb on lines 150..175
      lib/bcdice/game_system/RuinBreakers.rb on lines 232..257

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status