Sign upLogin

bcdice/BCDice

View on GitHub
Star
lib/bcdice/game_system/Ryutama.rb

Summary

Maintainability
B
6 hrs
Test Coverage
A
96%

Method eval_game_system_specific_command has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def eval_game_system_specific_command(command)
        debug('eval_game_system_specific_command begin')

        unless command =~ /^R(\d+)(,(\d+))?([+\-\d]+)?(>=(\d+))?/
          debug('unmatched!')
Severity: Minor
Found in lib/bcdice/game_system/Ryutama.rb - About 1 hr to fix

    Method getDiceType has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def getDiceType(dice1, dice2)
        debug('getDiceType begin')

        if dice2 != 0
          if isValidDiceOne(dice1)
    Severity: Minor
    Found in lib/bcdice/game_system/Ryutama.rb - About 1 hr to fix

      Method getResultText has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            def getResultText(value1, value2, dice1, dice2, difficulty, total)
      Severity: Minor
      Found in lib/bcdice/game_system/Ryutama.rb - About 45 mins to fix

        Method getDiceType has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

              def getDiceType(dice1, dice2)
        debug('getDiceType begin')

        if dice2 != 0
          if isValidDiceOne(dice1)
        Severity: Minor
        Found in lib/bcdice/game_system/Ryutama.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method eval_game_system_specific_command has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

              def eval_game_system_specific_command(command)
        debug('eval_game_system_specific_command begin')

        unless command =~ /^R(\d+)(,(\d+))?([+\-\d]+)?(>=(\d+))?/
          debug('unmatched!')
        Severity: Minor
        Found in lib/bcdice/game_system/Ryutama.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                  return dice1, dice2
        Severity: Major
        Found in lib/bcdice/game_system/Ryutama.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return "失敗"
          Severity: Major
          Found in lib/bcdice/game_system/Ryutama.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return 0, 0
            Severity: Major
            Found in lib/bcdice/game_system/Ryutama.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                        return diceBase, 0
              Severity: Major
              Found in lib/bcdice/game_system/Ryutama.rb - About 30 mins to fix

                There are no issues that match your filters.

                Category
                Status