Sign upLogin

bcdice/BCDice

View on GitHub
Star
lib/bcdice/game_system/SharedFantasia.rb

Summary

Maintainability
A
3 hrs
Test Coverage
A
100%

Method result_2d6 has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

      def result_2d6(total, dice_total, _dice_list, cmp_op, target)
        return Result.nothing if target == '?'
        return nil unless [:>=, :>].include?(cmp_op)

        critical = false
Severity: Minor
Found in lib/bcdice/game_system/SharedFantasia.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method result_2d6 has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def result_2d6(total, dice_total, _dice_list, cmp_op, target)
        return Result.nothing if target == '?'
        return nil unless [:>=, :>].include?(cmp_op)

        critical = false
Severity: Minor
Found in lib/bcdice/game_system/SharedFantasia.rb - About 1 hr to fix

    Method result_2d6 has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def result_2d6(total, dice_total, _dice_list, cmp_op, target)
    Severity: Minor
    Found in lib/bcdice/game_system/SharedFantasia.rb - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status