Sign upLogin

bcdice/BCDice

View on GitHub
Star
lib/bcdice/game_system/ShinobiGami.rb

Summary

Maintainability
F
3 days
Test Coverage
A
100%

File ShinobiGami.rb has 1148 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'bcdice/dice_table/table'

module BCDice
  module GameSystem
    class ShinobiGami < Base
Severity: Major
Found in lib/bcdice/game_system/ShinobiGami.rb - About 2 days to fix

    Method action_roll has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

          def action_roll(command)
        parser = Command::Parser.new(/\d*SG/, round_type: round_type)
                                .restrict_cmp_op_to(:>=, nil)
                                .enable_critical
                                .enable_fumble
    Severity: Minor
    Found in lib/bcdice/game_system/ShinobiGami.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method action_roll has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def action_roll(command)
        parser = Command::Parser.new(/\d*SG/, round_type: round_type)
                                .restrict_cmp_op_to(:>=, nil)
                                .enable_critical
                                .enable_fumble
    Severity: Minor
    Found in lib/bcdice/game_system/ShinobiGami.rb - About 1 hr to fix

      Method result_2d6 has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            def result_2d6(total, dice_total, _dice_list, cmp_op, target)
      Severity: Minor
      Found in lib/bcdice/game_system/ShinobiGami.rb - About 35 mins to fix

        Method result_2d6 has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

              def result_2d6(total, dice_total, _dice_list, cmp_op, target)
        return nil unless cmp_op == :>=

        if dice_total <= 2
          Result.fumble("ファンブル")
        Severity: Minor
        Found in lib/bcdice/game_system/ShinobiGami.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

              RTT = DiceTable::SaiFicSkillTable.new(
        [
          ['器術', ['絡繰術', '火術', '水術', '針術', '仕込み', '衣装術', '縄術', '登術', '拷問術', '壊器術', '掘削術']],
          ['体術', ['騎乗術', '砲術', '手裏剣術', '手練', '身体操術', '歩法', '走法', '飛術', '骨法術', '刀術', '怪力']],
          ['忍術', ['生存術', '潜伏術', '遁走術', '盗聴術', '腹話術', '隠形術', '変装術', '香術', '分身の術', '隠蔽術', '第六感']],
        Severity: Major
        Found in lib/bcdice/game_system/ShinobiGami.rb and 2 other locations - About 2 hrs to fix
        lib/bcdice/game_system/BloodCrusade.rb on lines 64..73
        lib/bcdice/game_system/PastFutureParadox.rb on lines 63..74

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 94.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status