bcdice/BCDice

View on GitHub
lib/bcdice/game_system/ShuumatsuBargainWars.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Similar blocks of code found in 11 locations. Consider refactoring.
Open

      WeaponItemTable = DiceTable::D66Table.new(
        '武器系アイテム表',
        D66SortType::ASC,
        {
          11 => 'アズキアイス',
Severity: Major
Found in lib/bcdice/game_system/ShuumatsuBargainWars.rb and 10 other locations - About 1 hr to fix
lib/bcdice/game_system/ShuumatsuBargainWars.rb on lines 33..57
lib/bcdice/game_system/ShuumatsuBargainWars.rb on lines 61..85
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 66..90
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 94..118
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 122..146
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 150..174
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 6..30
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 34..58
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 62..86
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 90..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

      RecoveryItemTable = DiceTable::D66Table.new(
        '回復系アイテム表',
        D66SortType::ASC,
        {
          11 => '飴玉',
Severity: Major
Found in lib/bcdice/game_system/ShuumatsuBargainWars.rb and 10 other locations - About 1 hr to fix
lib/bcdice/game_system/ShuumatsuBargainWars.rb on lines 61..85
lib/bcdice/game_system/ShuumatsuBargainWars.rb on lines 89..113
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 66..90
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 94..118
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 122..146
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 150..174
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 6..30
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 34..58
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 62..86
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 90..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

      ConvenienceItemTable = DiceTable::D66Table.new(
        '便利系アイテム表',
        D66SortType::ASC,
        {
          11 => 'ちくわ',
Severity: Major
Found in lib/bcdice/game_system/ShuumatsuBargainWars.rb and 10 other locations - About 1 hr to fix
lib/bcdice/game_system/ShuumatsuBargainWars.rb on lines 33..57
lib/bcdice/game_system/ShuumatsuBargainWars.rb on lines 89..113
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 66..90
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 94..118
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 122..146
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 150..174
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 6..30
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 34..58
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 62..86
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 90..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status