Sign upLogin

bcdice/BCDice

View on GitHub
Star
lib/bcdice/game_system/TokyoGhostResearch.rb

Summary

Maintainability
A
1 hr
Test Coverage
D
65%

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      def tgr_opening_table
        name = "導入表"
        table = [
          [1, "【病休中断】体調不良または怪我で療養中だったが強制召喚された。"],
          [2, "【忙殺中】別の業務で忙殺中であった。"],
Severity: Minor
Found in lib/bcdice/game_system/TokyoGhostResearch.rb and 1 other location - About 45 mins to fix
lib/bcdice/game_system/TokyoGhostResearch.rb on lines 94..108

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      def tgr_common_trouble_table
        name = "一般トラブル表"
        table = [
          [1, "トラブルが生じたが、間一髪、危機を脱した。【ダメージなし】"],
          [2, "どうにかタスクを処理したが、非常に疲労してしまった。【肉体ダメージ1点】"],
Severity: Minor
Found in lib/bcdice/game_system/TokyoGhostResearch.rb and 1 other location - About 45 mins to fix
lib/bcdice/game_system/TokyoGhostResearch.rb on lines 76..90

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status