Sign upLogin

bcdice/BCDice

View on GitHub
Star
lib/bcdice/game_system/Torg.rb

Summary

Maintainability
D
1 day
Test Coverage
A
96%

File Torg.rb has 291 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module BCDice
  module GameSystem
    class Torg < Base
      # ゲームシステムの識別子
      ID = 'Torg'
Severity: Minor
Found in lib/bcdice/game_system/Torg.rb - About 3 hrs to fix

    Method eval_game_system_specific_command has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def eval_game_system_specific_command(command)
        string = command.upcase
        string = replace_text(string)

        if (result = torg_check(string))
    Severity: Minor
    Found in lib/bcdice/game_system/Torg.rb - About 1 hr to fix

      Method torg_check has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def torg_check(string)
        unless /(^|\s)S?(1R20([+-]\d+)*)(\s|$)/i =~ string
          return nil
        end
      Severity: Minor
      Found in lib/bcdice/game_system/Torg.rb - About 1 hr to fix

        Method torg_dice has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

              def torg_dice
        isSkilledCritical = true
        isCritical = true
        skilled = 0
        unskilled = 0
        Severity: Minor
        Found in lib/bcdice/game_system/Torg.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method torg_check has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

              def torg_check(string)
        unless /(^|\s)S?(1R20([+-]\d+)*)(\s|$)/i =~ string
          return nil
        end
        Severity: Minor
        Found in lib/bcdice/game_system/Torg.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method eval_game_system_specific_command has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

              def eval_game_system_specific_command(command)
        string = command.upcase
        string = replace_text(string)

        if (result = torg_check(string))
        Severity: Minor
        Found in lib/bcdice/game_system/Torg.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              def get_torg_bonus(value)
        bonus_table = [
          [1, -12],
          [2, -10],
          [3, -8],
        Severity: Major
        Found in lib/bcdice/game_system/Torg.rb and 1 other location - About 1 hr to fix
        lib/bcdice/game_system/TorgEternity.rb on lines 421..443

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 70.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              def get_torg_damage_ords(value)
        damage_table_ords = [
          [0, "1"],
          [1, "O1"],
          [2, "K1"],
        Severity: Major
        Found in lib/bcdice/game_system/Torg.rb and 1 other location - About 1 hr to fix
        lib/bcdice/game_system/Torg.rb on lines 263..286

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 58.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              def get_torg_damage_posibility(value)
        damage_table_posibility = [
          [0, "1"],
          [1, "1"],
          [2, "O1"],
        Severity: Major
        Found in lib/bcdice/game_system/Torg.rb and 1 other location - About 1 hr to fix
        lib/bcdice/game_system/Torg.rb on lines 236..259

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 58.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                if mod
          if mod > 0
            output = "#{sk_bonus}[#{dice_str}]+#{mod}"
          else
            output = "#{sk_bonus}[#{dice_str}]#{mod}"
        Severity: Minor
        Found in lib/bcdice/game_system/Torg.rb and 1 other location - About 35 mins to fix
        lib/bcdice/game_system/TorgEternity.rb on lines 83..90

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 34.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status