Sign upLogin

bcdice/BCDice

View on GitHub
Star
lib/bcdice/game_system/TorgEternity.rb

Summary

Maintainability
D
2 days
Test Coverage
A
99%

File TorgEternity.rb has 391 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module BCDice
  module GameSystem
    class TorgEternity < Base
      # ゲームシステムの識別子
      ID = 'TorgEternity'
Severity: Minor
Found in lib/bcdice/game_system/TorgEternity.rb - About 5 hrs to fix

    Method torg_eternity_dice has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

          def torg_eternity_dice(check_pos, check_mishap)
        isSkilledCritical = true
        isCritical = true
        skilled = 0
        unskilled = 0
    Severity: Minor
    Found in lib/bcdice/game_system/TorgEternity.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getUpRollDiceCommandResult has 54 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def getUpRollDiceCommandResult(command)
        debug("Torg Eternity Dice Roll ( UP ) Command ? ", command)
        m = /^UP(\d*)$/i.match(command)
        unless m
          return nil
    Severity: Major
    Found in lib/bcdice/game_system/TorgEternity.rb - About 2 hrs to fix

      Method torg_eternity_dice has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def torg_eternity_dice(check_pos, check_mishap)
        isSkilledCritical = true
        isCritical = true
        skilled = 0
        unskilled = 0
      Severity: Minor
      Found in lib/bcdice/game_system/TorgEternity.rb - About 1 hr to fix

        Method getUpRollDiceCommandResult has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

              def getUpRollDiceCommandResult(command)
        debug("Torg Eternity Dice Roll ( UP ) Command ? ", command)
        m = /^UP(\d*)$/i.match(command)
        unless m
          return nil
        Severity: Minor
        Found in lib/bcdice/game_system/TorgEternity.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method get_torg_eternity_damage_bonus_dice has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

              def get_torg_eternity_damage_bonus_dice(number)
        debug("bonus dice roll : #{number}")
        value_roll = 0
        output_roll = ""
        if number > 0
        Severity: Minor
        Found in lib/bcdice/game_system/TorgEternity.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method torg_check has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def torg_check(string)
        string = replace_text(string)

        m = /^1R20(([+-]\d+)*)$/i.match(string)
        unless m
        Severity: Minor
        Found in lib/bcdice/game_system/TorgEternity.rb - About 1 hr to fix

          Method get_torg_eternity_damage_bonus_dice has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                def get_torg_eternity_damage_bonus_dice(number)
        debug("bonus dice roll : #{number}")
        value_roll = 0
        output_roll = ""
        if number > 0
          Severity: Minor
          Found in lib/bcdice/game_system/TorgEternity.rb - About 1 hr to fix

            Method torg_check has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                  def torg_check(string)
        string = replace_text(string)

        m = /^1R20(([+-]\d+)*)$/i.match(string)
        unless m
            Severity: Minor
            Found in lib/bcdice/game_system/TorgEternity.rb - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method getRolld20DiceCommandResult has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                  def getRolld20DiceCommandResult(command)
        debug("Torg Eternity Dice Roll Command ? ", command)
        unless command == "TE"
          return nil
        end
            Severity: Minor
            Found in lib/bcdice/game_system/TorgEternity.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  def get_torg_eternity_bonus(value)
        bonus_table = [
          [1, -10],
          [2, -8],
          [3, -6],
            Severity: Major
            Found in lib/bcdice/game_system/TorgEternity.rb and 1 other location - About 1 hr to fix
            lib/bcdice/game_system/Torg.rb on lines 335..360

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 70.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    if mod
          if mod > 0
            output = "#{sk_bonus}[#{dice_str}]+#{mod}"
          else
            output = "#{sk_bonus}[#{dice_str}]#{mod}"
            Severity: Minor
            Found in lib/bcdice/game_system/TorgEternity.rb and 1 other location - About 35 mins to fix
            lib/bcdice/game_system/Torg.rb on lines 64..71

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 34.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status