Sign upLogin

bcdice/BCDice

View on GitHub
Star
lib/bcdice/game_system/TrinitySeven.rb

Summary

Maintainability
C
1 day
Test Coverage
A
97%

File TrinitySeven.rb has 319 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require "bcdice/dice_table/table"
require "bcdice/format"

module BCDice
  module GameSystem
Severity: Minor
Found in lib/bcdice/game_system/TrinitySeven.rb - About 3 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          NAME2 = DiceTable::Table.new(
        "名字表",
        "1D100",
        [
          'アラタ/聖', # 1
    Severity: Major
    Found in lib/bcdice/game_system/TrinitySeven.rb and 1 other location - About 3 hrs to fix
    lib/bcdice/game_system/TrinitySeven.rb on lines 148..252

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 107.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          NAME1 = DiceTable::Table.new(
        "名字表",
        "1D100",
        [
          '春日', # 1
    Severity: Major
    Found in lib/bcdice/game_system/TrinitySeven.rb and 1 other location - About 3 hrs to fix
    lib/bcdice/game_system/TrinitySeven.rb on lines 255..359

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 107.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status