Sign upLogin

bcdice/BCDice

View on GitHub
Star
lib/bcdice/game_system/TwilightGunsmoke.rb

Summary

Maintainability
C
1 day
Test Coverage
A
98%

File TwilightGunsmoke.rb has 492 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'bcdice/dice_table/table'
require 'bcdice/dice_table/d66_range_table'
require 'bcdice/dice_table/d66_grid_table'
require 'bcdice/format'
Severity: Minor
Found in lib/bcdice/game_system/TwilightGunsmoke.rb - About 7 hrs to fix

    Method check_roll has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def check_roll(command)
        m = /^2D6([+\-\d]*)>=(\d+)(\[(\d+)?(,(\d+))?\])?$/i.match(command)
        unless m
          return nil
        end
    Severity: Minor
    Found in lib/bcdice/game_system/TwilightGunsmoke.rb - About 1 hr to fix

      Method check_roll has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

            def check_roll(command)
        m = /^2D6([+\-\d]*)>=(\d+)(\[(\d+)?(,(\d+))?\])?$/i.match(command)
        unless m
          return nil
        end
      Severity: Minor
      Found in lib/bcdice/game_system/TwilightGunsmoke.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status