Sign upLogin

bcdice/BCDice

View on GitHub
Star
lib/bcdice/game_system/Ventangle.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method eval_game_system_specific_command has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def eval_game_system_specific_command(command)
        debug("eval_game_system_specific_command Begin")

        parser = Command::Parser.new('VT', round_type: round_type)
                                .enable_critical
Severity: Minor
Found in lib/bcdice/game_system/Ventangle.rb - About 2 hrs to fix

    Method eval_game_system_specific_command has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

          def eval_game_system_specific_command(command)
        debug("eval_game_system_specific_command Begin")

        parser = Command::Parser.new('VT', round_type: round_type)
                                .enable_critical
    Severity: Minor
    Found in lib/bcdice/game_system/Ventangle.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method compare has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

          def compare(dice_total, total, cmd)
        special = cmd.critical || DEFAULT_SPECIAL_VALUE
        fumble = cmd.fumble || DEFAULT_FUMBLE_VALUE

        if dice_total <= fumble
    Severity: Minor
    Found in lib/bcdice/game_system/Ventangle.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

              return Result.new(nil)
    Severity: Major
    Found in lib/bcdice/game_system/Ventangle.rb - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status