Sign upLogin

bcdice/BCDice

View on GitHub
Star
lib/bcdice/game_system/WitchQuest.rb

Summary

Maintainability
B
6 hrs
Test Coverage
A
100%

Method getStructureEncounter has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def getStructureEncounter(number)
        debug("getStructureEncounter number", number)

        tables = [[1, ['船から降りてきた', '魚を売っている', '仕事で忙しそうな', '異国から来た', 'おもしろおかしい', '汗水流している']],
                  [2, ['おかしな格好をした', '歌を歌っている', 'ステキな笑顔をした', '日なたぼっこをしている', '悩んでいる', '旅をしている']],
Severity: Major
Found in lib/bcdice/game_system/WitchQuest.rb - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          def getPersonTable1()
        gotoNextTable = lambda { "表２へ" + getPersonTable2() }

        table = [[11, "おじさん"],
                 [12, "おばさん"],
    Severity: Major
    Found in lib/bcdice/game_system/WitchQuest.rb and 1 other location - About 1 hr to fix
    lib/bcdice/game_system/WitchQuest.rb on lines 170..200

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 75.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          def getPersonTable2()
        gotoNextTable = lambda { "表３へ" + getPersonTable3() }

        table = [[11, "魔法使い"],
                 [12, "観光客"],
    Severity: Major
    Found in lib/bcdice/game_system/WitchQuest.rb and 1 other location - About 1 hr to fix
    lib/bcdice/game_system/WitchQuest.rb on lines 137..167

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 75.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status