Sign upLogin

bcdice/BCDice

View on GitHub
Star
lib/bcdice/game_system/meikyu_kingdom_basic/name_table.rb

Summary

Maintainability
C
1 day
Test Coverage
B
84%

File name_table.rb has 382 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module BCDice
  module GameSystem
    class MeikyuKingdomBasic
      # エキゾチック名前表(D66)
      # override
Severity: Minor
Found in lib/bcdice/game_system/meikyu_kingdom_basic/name_table.rb - About 5 hrs to fix

    Method mk_new_name_table has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def mk_new_name_table
        nick_table = "1"
        name_table = "1"
        # 新名前表
        nick_n = @randomizer.roll_once(6)
    Severity: Minor
    Found in lib/bcdice/game_system/meikyu_kingdom_basic/name_table.rb - About 1 hr to fix

      Method mk_new_name_table has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

            def mk_new_name_table
        nick_table = "1"
        name_table = "1"
        # 新名前表
        nick_n = @randomizer.roll_once(6)
      Severity: Minor
      Found in lib/bcdice/game_system/meikyu_kingdom_basic/name_table.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if nick_n <= 1
          nick_table = mk_nick_pr_table(d1)
        elsif name_n <= 2
          nick_table = mk_nick_fo_table(d1)
        elsif name_n <= 3
      Severity: Minor
      Found in lib/bcdice/game_system/meikyu_kingdom_basic/name_table.rb and 1 other location - About 40 mins to fix
      lib/bcdice/game_system/meikyu_kingdom_basic/name_table.rb on lines 61..73

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 38.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if name_n <= 1
          name_table = mk_name_ar_table(d2)
        elsif name_n <= 2
          name_table = mk_name_fo_table(d2)
        elsif name_n <= 3
      Severity: Minor
      Found in lib/bcdice/game_system/meikyu_kingdom_basic/name_table.rb and 1 other location - About 40 mins to fix
      lib/bcdice/game_system/meikyu_kingdom_basic/name_table.rb on lines 46..58

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 38.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status