Sign upLogin

bcdice/BCDice

View on GitHub
Star
lib/bcdice/game_system/sword_world/transcendent_test.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method execute has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def execute(randomizer)
          if @critical_value < 3
            return translate("SwordWorld2_0.transcendent_critical_too_small", expression: @expression)
          end
Severity: Minor
Found in lib/bcdice/game_system/sword_world/transcendent_test.rb - About 1 hr to fix

    Method result_status has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

            def result_status(total_sum, n_value_groups, fumble, critical)
          return :no_target unless @target
          return :fumble if fumble
          return :critical if critical
    Severity: Minor
    Found in lib/bcdice/game_system/sword_world/transcendent_test.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            def initialize(critical_value, modifier, cmp_op, target, locale)
    Severity: Minor
    Found in lib/bcdice/game_system/sword_world/transcendent_test.rb - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status