bcgov/common-object-management-service

View on GitHub
app/src/middleware/upload.js

Summary

Maintainability
B
4 hrs
Test Coverage
A
100%

Function currentUpload has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

const currentUpload = (strict = false) => {
  return (req, _res, next) => {
    // Check Content-Length Header
    const contentLength = parseInt(req.get('Content-Length'));
    // TODO: Figure out what's killing and returning a 400 in response stack
Severity: Minor
Found in app/src/middleware/upload.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function currentUpload has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const currentUpload = (strict = false) => {
  return (req, _res, next) => {
    // Check Content-Length Header
    const contentLength = parseInt(req.get('Content-Length'));
    // TODO: Figure out what's killing and returning a 400 in response stack
Severity: Minor
Found in app/src/middleware/upload.js - About 1 hr to fix

    TODO found
    Open

        // TODO: Figure out what's killing and returning a 400 in response stack
    Severity: Minor
    Found in app/src/middleware/upload.js by fixme

    There are no issues that match your filters.

    Category
    Status