Showing 31 of 31 total issues
Method parse_http_request
has 40 lines of code (exceeds 25 allowed). Consider refactoring. Open
def parse_http_request(request)
# parse method
if request.to_s !~ /\A(GET|HEAD|DELETE|POST|PUT|OPTIONS) /
logger.warn('HTTP request method is not supported')
raise SSRFProxy::HTTP::Error::InvalidClientRequest,
Method handle_connection
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
def handle_connection(socket)
start_time = Time.now
_, port, host = socket.peeraddr
logger.debug("Client #{host}:#{port} connected")
request = socket.read
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid deeply nested control flow statements. Open
elsif response =~ /HTTPError: HTTP Error \d+/
if response =~ /HTTPError: HTTP Error 400: Bad Request/
result['code'] = 400
result['message'] = 'Bad Request'
elsif response =~ /HTTPError: HTTP Error 401: Unauthorized/
Avoid deeply nested control flow statements. Open
if response =~ /\[Errno -2\] Name or service not known/
result['code'] = 502
result['message'] = 'Bad Gateway'
elsif response =~ /\[Errno 101\] Network is unreachable/
result['code'] = 502
Similar blocks of code found in 2 locations. Consider refactoring. Open
if port_open?(@ssrf.url.host, @ssrf.url.port)
print_good('Connected to remote host ' \
"#{@ssrf.url.host}:#{@ssrf.url.port} successfully")
else
raise SSRFProxy::Server::Error::RemoteHostUnresponsive.new,
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 36.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
if port_open?(@ssrf.proxy.host, @ssrf.proxy.port)
print_good('Connected to remote proxy ' \
"#{@ssrf.proxy.host}:#{@ssrf.proxy.port} successfully")
else
raise SSRFProxy::Server::Error::RemoteProxyUnresponsive.new,
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 36.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Method run_rules
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def run_rules(url, rules)
str = url.to_s
return str if rules.nil?
rules.each do |rule|
case rule
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method parse_http_request
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def parse_http_request(request)
# parse method
if request.to_s !~ /\A(GET|HEAD|DELETE|POST|PUT|OPTIONS) /
logger.warn('HTTP request method is not supported')
raise SSRFProxy::HTTP::Error::InvalidClientRequest,
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this method. Open
return response_error
Avoid too many return
statements within this method. Open
return response_error
Method encode_ip
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def encode_ip(url, mode)
return if url.nil?
new_host = nil
host = URI.parse(url.to_s.split('?').first).host.to_s
begin
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"