bcomnes/gitpub

View on GitHub

Showing 15 of 15 total issues

Function exports has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function (req, res, next) {
  var pub = moment(req.body.published);
  debug('Staging Post');

  async.series([setFm,generateSlug,createPostFile],next)
Severity: Minor
Found in lib/stagePost.js - About 2 hrs to fix

    Function exports has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function (req, res, next) {
      debug('Looking for Files');
      if (req.files) {
        debug('Yes there are files')
        // Git FS File Handler
    Severity: Minor
    Found in lib/handleFiles.js - About 1 hr to fix

      Function exports has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

      module.exports = function (req, res, next) {
        req.tokenData = {};
        req.tokenData.token = req.get('Authorization') || 'Bearer ' + req.body.access_token;
        debug('Content-Type: ' + req.get('Content-Type'));
        var options = {
      Severity: Minor
      Found in lib/authorize.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function exports has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports = function (req, res, next) {
        req.tokenData = {};
        req.tokenData.token = req.get('Authorization') || 'Bearer ' + req.body.access_token;
        debug('Content-Type: ' + req.get('Content-Type'));
        var options = {
      Severity: Minor
      Found in lib/authorize.js - About 1 hr to fix

        Function exports has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        module.exports = function (req, res, next) {
          debug('Content-Type: ' + req.get('Content-Type'));
          if ( req.is('multipart') ) {
            debug('Its multipart!')
            // Handle file
        Severity: Minor
        Found in lib/multiParse.js - About 1 hr to fix

          Function exports has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

          module.exports = function (req, res, next) {
            debug('Content-Type: ' + req.get('Content-Type'));
            if ( req.is('multipart') ) {
              debug('Its multipart!')
              // Handle file
          Severity: Minor
          Found in lib/multiParse.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function setFm has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function setFm(cb) {
              var fm = {
                amessage: 'Hi dude!',
                anothermsg: 'hey',
                anothermsga: 'hey',
          Severity: Minor
          Found in prototypes/fmTest.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              this.git.exec('config', null, ['user.name',that.name || 'GitPub'], function(err, stdout) {
                if (err) cb(err);
                if (stdout) debug(stdout);
                debug('User Set');
                if (cb) cb(null);
            Severity: Minor
            Found in lib/repo.js and 1 other location - About 40 mins to fix
            lib/repo.js on lines 70..75

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 48.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              this.git.exec('config', null, ['user.email',that.email],function (err, stdout) {
                  if (err) cb(err);
                  if (stdout) debug(stdout);
                  debug('Email Set');
                  if (cb) cb(null);
            Severity: Minor
            Found in lib/repo.js and 1 other location - About 40 mins to fix
            lib/repo.js on lines 59..64

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 48.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              this.git.exec('pull', this.remoteBranch, function(err, stdout) {
                if (err) cb(err);
                if (stdout) debug(stdout);
                debug('Finished pulling repo');
                if (cb) cb();
            Severity: Minor
            Found in lib/repo.js and 1 other location - About 35 mins to fix
            lib/repo.js on lines 95..100

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              this.git.exec('commit', {m: true}, comMsg, function (err, stdout) {
                if (err) cb(err);
                if (stdout) debug(stdout);
                debug ('Changes committed');
                if (cb) cb();
            Severity: Minor
            Found in lib/repo.js and 1 other location - About 35 mins to fix
            lib/repo.js on lines 48..53

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            if (process.env.ENV === 'development') {
              settings.repo = 'git@github.com:' + config.github.user + '/' + config.github.repo + '.git';
            } else {
            Severity: Minor
            Found in settings.js and 1 other location - About 35 mins to fix
            settings.js on lines 9..11

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            } else {
              settings.repo = 'https://github.com/' + config.github.user + '/' + config.github.repo + '.git';
            }
            Severity: Minor
            Found in settings.js and 1 other location - About 35 mins to fix
            settings.js on lines 7..9

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function pull has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            Repo.prototype.pull = function(cb) {
              debug('Pulling ' + this.worktree);
              this.git.exec('pull', this.remoteBranch, function(err, stdout) {
                if (err) cb(err);
                if (stdout) debug(stdout);
            Severity: Minor
            Found in lib/repo.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function push has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            Repo.prototype.push = function(cb) {
              debug('Pushing to ' + this.remoteBranch);
              this.git.exec('push', this.remoteBranch, function (err, stdout) {
                if (err) debug(err);
                debug('Push Succeeded');
            Severity: Minor
            Found in lib/repo.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language