bdmac/strong_password

View on GitHub

Showing 6 of 6 total issues

File dictionary_adjuster.rb has 992 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module StrongPassword   
  class DictionaryAdjuster
   COMMON_PASSWORDS = 
    %w( password 123456 12345678 1234 qwerty 12345 dragon pussy baseball 
        football letmein monkey 696969 abc123 mustang michael shadow master jennifer 111111
Severity: Major
Found in lib/strong_password/dictionary_adjuster.rb - About 2 days to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        KEYBOARDMAP_DOWNRIGHT = {
          "a" => "z",
          "q" => "a",
          "1" => "q",
          "s" => "x",
    Severity: Major
    Found in lib/strong_password/password_variants.rb and 1 other location - About 1 hr to fix
    lib/strong_password/password_variants.rb on lines 54..80

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        KEYBOARDMAP_DOWNLEFT = {
          "2" => "q",
          "w" => "a",
          "3" => "w",
          "s" => "z",
    Severity: Major
    Found in lib/strong_password/password_variants.rb and 1 other location - About 1 hr to fix
    lib/strong_password/password_variants.rb on lines 25..51

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method calculate_bonus_bits_for has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def self.calculate_bonus_bits_for(password)
          upper   = !!(password =~ /[[:upper:]]/)
              lower   = !!(password =~ /[[:lower:]]/)
              numeric = !!(password =~ /[[:digit:]]/)
              other   = !!(password =~ /[^a-zA-Z0-9 ]/)
    Severity: Minor
    Found in lib/strong_password/nist_bonus_bits.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method extra_words_for_object has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def extra_words_for_object(extra_words, object)
            return [] unless extra_words.present?
            if object
              if extra_words.respond_to?(:call)
                extra_words = extra_words.call(object)
    Severity: Minor
    Found in lib/active_model/validations/password_strength_validator.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method bits has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def self.bits(password)
          length = password.length
          bits = if length > 20
            4 + (7 * 2) + (12 * 1.5) + length - 20
          elsif length > 8
    Severity: Minor
    Found in lib/strong_password/entropy_calculator.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language