Sign upLogin

bdmac/strong_password

View on GitHub
Star

Showing 4 of 6 total issues

File dictionary_adjuster.rb has 992 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module StrongPassword   
  class DictionaryAdjuster
   COMMON_PASSWORDS = 
    %w( password 123456 12345678 1234 qwerty 12345 dragon pussy baseball 
        football letmein monkey 696969 abc123 mustang michael shadow master jennifer 111111
Severity: Major
Found in lib/strong_password/dictionary_adjuster.rb - About 2 days to fix

    Method calculate_bonus_bits_for has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def self.calculate_bonus_bits_for(password)
      upper   = !!(password =~ /[[:upper:]]/)
          lower   = !!(password =~ /[[:lower:]]/)
          numeric = !!(password =~ /[[:digit:]]/)
          other   = !!(password =~ /[^a-zA-Z0-9 ]/)
    Severity: Minor
    Found in lib/strong_password/nist_bonus_bits.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method bits has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def self.bits(password)
      length = password.length
      bits = if length > 20
        4 + (7 * 2) + (12 * 1.5) + length - 20
      elsif length > 8
    Severity: Minor
    Found in lib/strong_password/entropy_calculator.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method extra_words_for_object has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def extra_words_for_object(extra_words, object)
        return [] unless extra_words.present?
        if object
          if extra_words.respond_to?(:call)
            extra_words = extra_words.call(object)
    Severity: Minor
    Found in lib/active_model/validations/password_strength_validator.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language