Sign upLogin

bdurand/sidekiq-transaction_guard

View on GitHub
Star
lib/sidekiq/transaction_guard/middleware.rb

Summary

Maintainability
A
0 mins
Test Coverage

Method log_transaction has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Wontfix

      def log_transaction(worker_class, job)
        mode = worker_mode(job)
        if mode != :disabled
          message = "#{worker_class.name} was called from inside a database transaction"
          if mode == :error
Severity: Minor
Found in lib/sidekiq/transaction_guard/middleware.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method notify! has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Wontfix

      def notify!(worker_class, job)
        notify_handler = notify_block(job)
        if notify_handler
          begin
            notify_handler.call(job)
Severity: Minor
Found in lib/sidekiq/transaction_guard/middleware.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status