Sign upLogin

bdurand/us_geo

View on GitHub
Star
explorer_app/app/helpers/application_helper.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method breadcrumb_links has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

  def breadcrumb_links(active = nil)
    return {} if @breadcrumbs.blank?

    objects = @breadcrumbs.values
    region = objects.detect { |b| b.is_a?(USGeo::Region) }
Severity: Minor
Found in explorer_app/app/helpers/application_helper.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method breadcrumb_links has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def breadcrumb_links(active = nil)
    return {} if @breadcrumbs.blank?

    objects = @breadcrumbs.values
    region = objects.detect { |b| b.is_a?(USGeo::Region) }
Severity: Minor
Found in explorer_app/app/helpers/application_helper.rb - About 1 hr to fix

    Method density has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def density(density)
    return nil unless density

    round = if density < 1
      3
    Severity: Minor
    Found in explorer_app/app/helpers/application_helper.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method auto_round has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def auto_round(number)
    return number unless number.is_a?(Float)

    decimals = if number < 1
      3
    Severity: Minor
    Found in explorer_app/app/helpers/application_helper.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status