Sign upLogin

be9/acl9

View on GitHub
Star
lib/acl9/model_extensions/for_subject.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method delete_role has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

      def delete_role(role)
        if role
          if ret = _role_objects.delete(role)
            if role.send(_auth_subject_class_name.demodulize.tableize).empty?
              ret &&= role.destroy unless role.respond_to?(:system?) && role.system?
Severity: Minor
Found in lib/acl9/model_extensions/for_subject.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method role_selecting_lambda has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def role_selecting_lambda(object)
        case object
        when Class
          lambda { |role| role.authorizable_type == object.to_s }
        when default
Severity: Minor
Found in lib/acl9/model_extensions/for_subject.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status