Showing 42 of 42 total issues
Ffprober::Ffmpeg::Finder#windows? doesn't depend on instance state (maybe move it to another class?) Open
Open
def windows?- Read upRead up
- Exclude checks
A Utility Function is any instance method that has no dependency on the state of the instance.
Ffprober::Ffmpeg::Version#nightly? performs a nil-check Open
Open
!(ffprobe_version_output =~ NIGHTLY_REGEX).nil?- Read upRead up
- Exclude checks
A NilCheck is a type check. Failures of NilCheck violate the "tell, don't ask" principle.
Additionally, type checks often mask bigger problems in your source code like not using OOP and / or polymorphism when you should.
Example
Given
class Klass
def nil_checker(argument)
if argument.nil?
puts "argument isn't nil!"
end
end
endReek would emit the following warning:
test.rb -- 1 warning:
[3]:Klass#nil_checker performs a nil-check. (NilCheck)