Sign upLogin

beardcoder/sitemap_generator

View on GitHub
Star

Showing 16 of 27 total issues

Function mapToEntries has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    protected function mapToEntries(array $typoScriptUrlEntry): void
    {
        if ($typoScriptUrlEntry['table'] && $typoScriptUrlEntry['active'] == 1) {
            $records = $this->getRecordsFromDatabase($typoScriptUrlEntry);
            if ($this->getDatabaseConnection()->sql_num_rows($records) !== 0) {
Severity: Minor
Found in Classes/Domain/Repository/SitemapRepository.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File SitemapRepository.php has 320 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
namespace Markussom\SitemapGenerator\Domain\Repository;

use TYPO3\CMS\Core\Cache\Frontend\FrontendInterface;
use Exception;
Severity: Minor
Found in Classes/Domain/Repository/SitemapRepository.php - About 3 hrs to fix

    The class SitemapRepository has an overall complexity of 68 which is very high. The configured complexity threshold is 50.
    Open

    class SitemapRepository
{
    /**
     * @var FieldValueService
     */
    Severity: Minor
    Found in Classes/Domain/Repository/SitemapRepository.php by phpmd

    Function mapGoogleNewsEntries has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function mapGoogleNewsEntries(array $typoScriptUrlEntry): array
    {
        $records = $this->getRecordsFromDatabase($typoScriptUrlEntry);
        $urlEntries = [];
        if ($this->getDatabaseConnection()->sql_num_rows($records) !== 0) {
    Severity: Minor
    Found in Classes/Domain/Repository/SitemapRepository.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getOrderByString has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function getOrderByString($orderBy, $tablename): string
    {
        if (isset($orderBy) && !empty($orderBy)) {
            $cleanOrderByParts = [];
            $tableColumns = $GLOBALS['TCA'][$tablename]['columns'];
    Severity: Minor
    Found in Classes/Service/OrderByService.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    SitemapRepository has 22 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class SitemapRepository
{
    /**
     * @var FieldValueService
     */
    Severity: Minor
    Found in Classes/Domain/Repository/SitemapRepository.php - About 2 hrs to fix

      Method mapToEntries has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function mapToEntries(array $typoScriptUrlEntry): void
    {
        if ($typoScriptUrlEntry['table'] && $typoScriptUrlEntry['active'] == 1) {
            $records = $this->getRecordsFromDatabase($typoScriptUrlEntry);
            if ($this->getDatabaseConnection()->sql_num_rows($records) !== 0) {
      Severity: Minor
      Found in Classes/Domain/Repository/SitemapRepository.php - About 1 hr to fix

        Method mapGoogleNewsEntries has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function mapGoogleNewsEntries(array $typoScriptUrlEntry): array
    {
        $records = $this->getRecordsFromDatabase($typoScriptUrlEntry);
        $urlEntries = [];
        if ($this->getDatabaseConnection()->sql_num_rows($records) !== 0) {
        Severity: Minor
        Found in Classes/Domain/Repository/SitemapRepository.php - About 1 hr to fix

          Method getRecordsFromDatabase has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function getRecordsFromDatabase($typoScriptUrlEntry)
    {
        if (!isset($GLOBALS['TCA'][$typoScriptUrlEntry['table']])
            || !is_array($GLOBALS['TCA'][$typoScriptUrlEntry['table']]['ctrl'])
        ) {
          Severity: Minor
          Found in Classes/Domain/Repository/SitemapRepository.php - About 1 hr to fix

            Function getEntriesFromPages has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getEntriesFromPages($pages): void
    {
        foreach ($pages as $page) {
            if ($this->hasPageAnAllowedDoktype($page)) {
                $urlEntry = GeneralUtility::makeInstance(UrlEntry::class);
            Severity: Minor
            Found in Classes/Domain/Repository/SitemapRepository.php - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid deeply nested control flow statements.
            Open

                                    if (isset($typoScriptUrlEntry['lastmod'])) {
                            $urlEntry->setLastmod(
                                date(
                                    'Y-m-d',
                                    $this->fieldValueService->getFieldValue('lastmod', $typoScriptUrlEntry, $row)
            Severity: Major
            Found in Classes/Domain/Repository/SitemapRepository.php - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                      if (isset($typoScriptUrlEntry['priority'])) {
                            $urlEntry->setPriority(
                                number_format(
                                    $this->fieldValueService->getFieldValue('priority', $typoScriptUrlEntry, $row) / 10,
                                    1,
              Severity: Major
              Found in Classes/Domain/Repository/SitemapRepository.php - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                        if (isset($typoScriptUrlEntry['changefreq'])) {
                            $urlEntry->setChangefreq(
                                $this->fieldValueService->getFieldValue('changefreq', $typoScriptUrlEntry, $row)
                            );
                        }
                Severity: Major
                Found in Classes/Domain/Repository/SitemapRepository.php - About 45 mins to fix

                  Function hidePagesIfNotTranslated has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      private function hidePagesIfNotTranslated(array $pages): array
    {
        $language = GeneralUtility::_GET('L');
        if ($this->isPageNotTranslated($language)) {
            foreach ($pages as $key => $page) {
                  Severity: Minor
                  Found in Classes/Domain/Repository/SitemapRepository.php - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function getLimitString has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public static function getLimitString($limit)
    {
        if (isset($limit) && !empty($limit)) {
            $limitParts = GeneralUtility::trimExplode(',', $limit);
            if (count($limitParts) === 1) {
                  Severity: Minor
                  Found in Classes/Service/LimitService.php - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  The method getOrderByString() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
                  Open

                      public static function getOrderByString($orderBy, $tablename): string
    {
        if (isset($orderBy) && !empty($orderBy)) {
            $cleanOrderByParts = [];
            $tableColumns = $GLOBALS['TCA'][$tablename]['columns'];
                  Severity: Minor
                  Found in Classes/Service/OrderByService.php by phpmd

                  CyclomaticComplexity

                  Since: 0.1

                  Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                  Example

                  // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

                  Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                  Severity
                  Category
                  Status
                  Source
                  Language