Sign upLogin

beatrichartz/exchange

View on GitHub
Star
lib/exchange/external_api/call.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method load_url has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

        def load_url url, retries, retry_with
          begin            
            result = URI.parse(url).open.read
          rescue SocketError
            raise APIError.new("Calling API #{url} produced a socket error")
Severity: Minor
Found in lib/exchange/external_api/call.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def initialize url, options={}, &block
        Exchange::GemLoader.new(options[:format] == :xml ? 'nokogiri' : 'json').try_load
                
        result = cache_config.subclass.cached(options[:api] || config.subclass, options) do
          load_url(url, options[:retries] || config.retries, options[:retry_with])
Severity: Minor
Found in lib/exchange/external_api/call.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status