Sign upLogin

beattyml1/metatonic-platform

View on GitHub
Star
metatonic-core/src/services/BuiltInValidations.ts

Summary

Maintainability
A
3 hrs
Test Coverage

Function required has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

export const required: Validation = function required(value, field, validation, time, params)  {
Severity: Minor
Found in metatonic-core/src/services/BuiltInValidations.ts - About 35 mins to fix

    Function regexValidaiton has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    export const regexValidaiton: Validation<any> = function regex(value, field, validation, time, params)  {
    Severity: Minor
    Found in metatonic-core/src/services/BuiltInValidations.ts - About 35 mins to fix

      Function maxLength has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      export const maxLength: Validation = function maxLength(value, field, validation, time, params)  {
      Severity: Minor
      Found in metatonic-core/src/services/BuiltInValidations.ts - About 35 mins to fix

        Function min has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        export const min: Validation = function min(value, field, validation, time, params) {
        Severity: Minor
        Found in metatonic-core/src/services/BuiltInValidations.ts - About 35 mins to fix

          Function max has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          export const max: Validation = function max(value, field, validation, time, params) {
          Severity: Minor
          Found in metatonic-core/src/services/BuiltInValidations.ts - About 35 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Wontfix

            export const max: Validation = function max(value, field, validation, time, params) {
    if (!isNonEmptyComparable(value)) return [];

    let max = params;
    let maxVal = value.constructor.fromData(max);
            Severity: Major
            Found in metatonic-core/src/services/BuiltInValidations.ts and 1 other location - About 3 hrs to fix
            metatonic-core/src/services/BuiltInValidations.ts on lines 11..18

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 113.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Wontfix

            export const min: Validation = function min(value, field, validation, time, params) {
    if(!isNonEmptyComparable(value)) return [];

    let min = params;
    let minVal = value.constructor.fromData(min);
            Severity: Major
            Found in metatonic-core/src/services/BuiltInValidations.ts and 1 other location - About 3 hrs to fix
            metatonic-core/src/services/BuiltInValidations.ts on lines 20..27

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 113.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status