Sign upLogin

bekeplar/Store-Manager

View on GitHub
Star

Showing 21 of 21 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    def product_validation(
        self,
        product_name,
        product_id,
        product_quantity,
Severity: Major
Found in api/validators.py and 1 other location - About 1 day to fix
api/validators.py on lines 56..87

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 179.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    def sales_validation(
        self,
        product_name,
        sale_id,
        product_quantity,
Severity: Major
Found in api/validators.py and 1 other location - About 1 day to fix
api/validators.py on lines 7..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 179.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function sales_validation has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    def sales_validation(
        self,
        product_name,
        sale_id,
        product_quantity,
Severity: Minor
Found in api/validators.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function product_validation has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    def product_validation(
        self,
        product_name,
        product_id,
        product_quantity,
Severity: Minor
Found in api/validators.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

            return "quantity is missing"
Severity: Major
Found in api/validators.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                return "quantity should be at least 1 item"
    Severity: Major
    Found in api/validators.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return "price must be only digits and must have no white spaces"
      Severity: Major
      Found in api/validators.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return "price should be greater than zero"
        Severity: Major
        Found in api/validators.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return "price is missing"
          Severity: Major
          Found in api/validators.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return "price should be greater than zero"
            Severity: Major
            Found in api/validators.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return "price is missing"
              Severity: Major
              Found in api/validators.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                            return "quantity is missing"
                Severity: Major
                Found in api/validators.py - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                              return "price is missing"
                  Severity: Major
                  Found in api/validators.py - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                return "quantity should be at least 1 item"
                    Severity: Major
                    Found in api/validators.py - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                  return "price must be only digits "
                      Severity: Major
                      Found in api/validators.py - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                    return "product_name should be more than 2 characters"
                        Severity: Major
                        Found in api/validators.py - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                      return "quantity is missing"
                          Severity: Major
                          Found in api/validators.py - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                        return "price is missing"
                            Severity: Major
                            Found in api/validators.py - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                          return "product_name should be more than 2 characters long"
                              Severity: Major
                              Found in api/validators.py - About 30 mins to fix

                                Avoid too many return statements within this function.
                                Open

                                            return "quantity is missing"
                                Severity: Major
                                Found in api/validators.py - About 30 mins to fix
                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language