Showing 19 of 21 total issues
Function sales_validation has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
Open
def sales_validation(
self,
product_name,
sale_id,
product_quantity,- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function product_validation has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
Open
def product_validation(
self,
product_name,
product_id,
product_quantity,- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return statements within this function. Open
Open
return "quantity is missing"Avoid too many return statements within this function. Open
Open
return "quantity should be at least 1 item"Avoid too many return statements within this function. Open
Open
return "price must be only digits and must have no white spaces"Avoid too many return statements within this function. Open
Open
return "price should be greater than zero"Avoid too many return statements within this function. Open
Open
return "price is missing"Avoid too many return statements within this function. Open
Open
return "price should be greater than zero"Avoid too many return statements within this function. Open
Open
return "price is missing"Avoid too many return statements within this function. Open
Open
return "quantity is missing"Avoid too many return statements within this function. Open
Open
return "price is missing"Avoid too many return statements within this function. Open
Open
return "quantity should be at least 1 item"Avoid too many return statements within this function. Open
Open
return "price must be only digits "Avoid too many return statements within this function. Open
Open
return "product_name should be more than 2 characters"Avoid too many return statements within this function. Open
Open
return "quantity is missing"Avoid too many return statements within this function. Open
Open
return "price is missing"Avoid too many return statements within this function. Open
Open
return "product_name should be more than 2 characters long"Avoid too many return statements within this function. Open
Open
return "quantity is missing"Function delete_products has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
def delete_products(self, product_id):
if len(self.products) > 0:
for product in self.products:
if product['product_id'] == product_id:
self.products.remove(product)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"