Sign upLogin

bemusic/bms-js

View on GitHub
Star

Showing 13 of 13 total issues

Function compile has 78 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.compile = function (text, options) {

  options = options || { }

  var chart = new BMSChart()
Severity: Major
Found in compiler/index.js - About 3 hrs to fix

    Function Timing has 52 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function Timing (initialBPM, actions) {
  var state = { bpm: initialBPM, beat: 0, seconds: 0 }
  var segments = [ ]
  segments.push({
    t: 0,
    Severity: Major
    Found in timing/index.js - About 2 hrs to fix

      Function fromBMSChart has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      SongInfo.fromBMSChart = function (chart) {
  var info       = { }
  var title      = chart.headers.get('title')
  var artist     = chart.headers.get('artist')
  var genre      = chart.headers.get('genre')
      Severity: Minor
      Found in song-info/index.js - About 1 hr to fix

        Function fromBMSChart has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        Positioning.fromBMSChart = function (chart) {
  var segments = [ ]
  var x = 0
  segments.push({
    t: 0,
        Severity: Minor
        Found in positioning/index.js - About 1 hr to fix

          Function fromBMSChart has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          Spacing.fromBMSChart = function (chart) {
  var segments = [ ]

  chart.objects.allSorted().forEach(function (object) {
    if (object.channel === 'SP') {
          Severity: Minor
          Found in spacing/index.js - About 1 hr to fix

            Function fromBMSChart has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

            SongInfo.fromBMSChart = function (chart) {
  var info       = { }
  var title      = chart.headers.get('title')
  var artist     = chart.headers.get('artist')
  var genre      = chart.headers.get('genre')
            Severity: Minor
            Found in song-info/index.js - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function compile has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

            exports.compile = function (text, options) {

  options = options || { }

  var chart = new BMSChart()
            Severity: Minor
            Found in compiler/index.js - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            Positioning.prototype.speed = function (beat) {
  return this._speedcore.dx(beat)
}
            Severity: Minor
            Found in positioning/index.js and 1 other location - About 45 mins to fix
            positioning/index.js on lines 46..48

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 50.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            Positioning.prototype.position = function (beat) {
  return this._speedcore.x(beat)
}
            Severity: Minor
            Found in positioning/index.js and 1 other location - About 45 mins to fix
            positioning/index.js on lines 36..38

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 50.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  segments.push({
        t: seconds,
        x: beat,
        dx: state.bpm / 60,
        bpm: state.bpm,
            Severity: Minor
            Found in timing/index.js and 1 other location - About 40 mins to fix
            timing/index.js on lines 74..80

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 49.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  segments.push({
        t: seconds,
        x: beat,
        dx: state.bpm / 60,
        bpm: state.bpm,
            Severity: Minor
            Found in timing/index.js and 1 other location - About 40 mins to fix
            timing/index.js on lines 57..63

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 49.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function add has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            BMSObjects.prototype.add = function (object) {
  if (object.channel !== '01') {
    for (var i = 0; i < this._objects.length; i++) {
      var test = this._objects[i]
      if (test.channel === object.channel &&
            Severity: Minor
            Found in bms/objects.js - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function match has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            function match (text) {
  var matched = false
  return {
    when: function (pattern, callback) {
      if (matched) return this
            Severity: Minor
            Found in util/match.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language