Sign upLogin

bencao/acts_as_brand_new_copy

View on GitHub
Star

Showing 7 of 7 total issues

Method calculate_save_order has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    def calculate_save_order
      constraints, klasses = Set.new, Set.new
      traverse do |current_hash|
        klasses.add(current_hash['klass']) unless klasses.include?(current_hash['klass'])
Severity: Minor
Found in lib/acts_as_brand_new_copy/builder.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class Builder has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Builder
    def initialize(serialized_hash)
      @hash_origin  = serialized_hash
      @hash_copy    = JSON.parse(serialized_hash.to_json) # a way to do deep clone
      @save_order   = calculate_save_order
Severity: Minor
Found in lib/acts_as_brand_new_copy/builder.rb - About 2 hrs to fix

    Method calculate_save_order has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def calculate_save_order
      constraints, klasses = Set.new, Set.new
      traverse do |current_hash|
        klasses.add(current_hash['klass']) unless klasses.include?(current_hash['klass'])
    Severity: Minor
    Found in lib/acts_as_brand_new_copy/builder.rb - About 1 hr to fix

      Method sanitize_copy_param has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        def sanitize_copy_param(name, param)
    return [] if param.nil?

    unless param.is_a?(Array)
      raise "#{name} param must be an array"
      Severity: Minor
      Found in lib/acts_as_brand_new_copy.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method copy_dependencies_for_join_type has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

                self_class,
          association_class,
          join_table_class,
          self_key_on_join_table,
          association_key_on_join_table
      Severity: Minor
      Found in lib/acts_as_brand_new_copy/serializer.rb - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            def copy_dependencies_for_has_one_or_has_many(reflection)
      self_class                    = Standard.reflection_self_name(reflection)
      association_class             = Standard.reflection_association_name(reflection)
      self_key_on_association_table = reflection.foreign_key
      {
        Severity: Minor
        Found in lib/acts_as_brand_new_copy/serializer.rb and 1 other location - About 15 mins to fix
        lib/acts_as_brand_new_copy/serializer.rb on lines 166..173

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 26.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            def copy_dependencies_for_belongs_to(reflection)
      self_class                    = Standard.reflection_self_name(reflection)
      association_class             = Standard.reflection_association_name(reflection)
      association_key_on_self_table = reflection.foreign_key
      {
        Severity: Minor
        Found in lib/acts_as_brand_new_copy/serializer.rb and 1 other location - About 15 mins to fix
        lib/acts_as_brand_new_copy/serializer.rb on lines 155..162

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 26.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language