Sign upLogin

bendrucker/convex-firebase

View on GitHub
Star

Showing 9 of 9 total issues

Function exports has 67 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function (ConvexCollection, Firebase, $rootScope) {

  ConvexCollection.prototype.$ref = function () {
    if (this.$$ref) return this.$$ref;
    var proto = this.$$model.prototype;
Severity: Major
Found in src/collection.js - About 2 hrs to fix

    Function exports has 51 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function (ConvexModel, Firebase, $q, $rootScope, convexConfig) {

  ConvexModel.prototype.$ref = function (collection) {
    var pathOverride = this.$firebase && this.$firebase.path;
    return new Firebase(convexConfig.firebase)
    Severity: Major
    Found in src/model.js - About 2 hrs to fix

      Function exports has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

      module.exports = function (ConvexModel, Firebase, $q, $rootScope, convexConfig) {

  ConvexModel.prototype.$ref = function (collection) {
    var pathOverride = this.$firebase && this.$firebase.path;
    return new Firebase(convexConfig.firebase)
      Severity: Minor
      Found in src/model.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function $subscribe has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        ConvexModel.prototype.$subscribe = function (keys, prefix) {
    var self = this;
    var refs;
    if (keys) {
      prefix = prefix ? '$$' : '';
      Severity: Minor
      Found in src/model.js - About 1 hr to fix

        Function exports has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        module.exports = function(config) {
  config.set({
    frameworks: ['mocha', 'chai-sinon', 'browserify'],
    files: [
      './node_modules/angular/angular.js',
        Severity: Minor
        Found in karma.conf.js - About 1 hr to fix

          Function exports has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          module.exports = function (ConvexCollection, Firebase, $rootScope) {

  ConvexCollection.prototype.$ref = function () {
    if (this.$$ref) return this.$$ref;
    var proto = this.$$model.prototype;
          Severity: Minor
          Found in src/collection.js - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              ref.on('child_removed', function (snapshot) {
      applyAsync(function () {
        this.$splice(snapshot.key());
      }, this);
    }, this);
          Severity: Minor
          Found in src/collection.js and 1 other location - About 45 mins to fix
          src/model.js on lines 45..49

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                ref.on('value', function (snapshot) {
        applyAsync(function () {
          this.$set(snapshot.val());
        }, this);
      }, this);
          Severity: Minor
          Found in src/model.js and 1 other location - About 45 mins to fix
          src/collection.js on lines 58..62

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function exports has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          module.exports = function (ConvexModel, Firebase, $q, $rootScope, convexConfig) {
          Severity: Minor
          Found in src/model.js - About 35 mins to fix
            Severity
            Category
            Status
            Source
            Language