bendrucker/convex-firebase

View on GitHub

Showing 7 of 9 total issues

Function exports has 67 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function (ConvexCollection, Firebase, $rootScope) {

  ConvexCollection.prototype.$ref = function () {
    if (this.$$ref) return this.$$ref;
    var proto = this.$$model.prototype;
Severity: Major
Found in src/collection.js - About 2 hrs to fix

    Function exports has 51 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function (ConvexModel, Firebase, $q, $rootScope, convexConfig) {
    
      ConvexModel.prototype.$ref = function (collection) {
        var pathOverride = this.$firebase && this.$firebase.path;
        return new Firebase(convexConfig.firebase)
    Severity: Major
    Found in src/model.js - About 2 hrs to fix

      Function exports has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

      module.exports = function (ConvexModel, Firebase, $q, $rootScope, convexConfig) {
      
        ConvexModel.prototype.$ref = function (collection) {
          var pathOverride = this.$firebase && this.$firebase.path;
          return new Firebase(convexConfig.firebase)
      Severity: Minor
      Found in src/model.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function $subscribe has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        ConvexModel.prototype.$subscribe = function (keys, prefix) {
          var self = this;
          var refs;
          if (keys) {
            prefix = prefix ? '$$' : '';
      Severity: Minor
      Found in src/model.js - About 1 hr to fix

        Function exports has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        module.exports = function(config) {
          config.set({
            frameworks: ['mocha', 'chai-sinon', 'browserify'],
            files: [
              './node_modules/angular/angular.js',
        Severity: Minor
        Found in karma.conf.js - About 1 hr to fix

          Function exports has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          module.exports = function (ConvexCollection, Firebase, $rootScope) {
          
            ConvexCollection.prototype.$ref = function () {
              if (this.$$ref) return this.$$ref;
              var proto = this.$$model.prototype;
          Severity: Minor
          Found in src/collection.js - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function exports has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          module.exports = function (ConvexModel, Firebase, $q, $rootScope, convexConfig) {
          Severity: Minor
          Found in src/model.js - About 35 mins to fix
            Severity
            Category
            Status
            Source
            Language