Sign upLogin

beneggett/sportradar-api

View on GitHub
Star
lib/sportradar/api/soccer/match.rb

Summary

Maintainability
D
2 days
Test Coverage

Class Match has 55 methods (exceeds 20 allowed). Consider refactoring.
Open

      class Match < Data
        attr_reader :id, :league_group, :scheduled, :start_time_tbd, :status, :tournament_round, :match_status, :venue
        attr_reader :home_score, :away_score, :winner_id, :aggregate_home_score, :aggregate_away_score, :aggregate_winner_id
        attr_reader :referee, :weather_info, :coverage_info, :probabilities
        attr_reader :home, :away, :tournament_id
Severity: Major
Found in lib/sportradar/api/soccer/match.rb - About 7 hrs to fix

    Method update has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
    Open

            def update(data, **opts)
          if data["sport_event"]
            update(data["sport_event"])
          end
          if data["sport_event_status"]
    Severity: Minor
    Found in lib/sportradar/api/soccer/match.rb - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File match.rb has 331 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    module Sportradar
  module Api
    module Soccer
      class Match < Data
        attr_reader :id, :league_group, :scheduled, :start_time_tbd, :status, :tournament_round, :match_status, :venue
    Severity: Minor
    Found in lib/sportradar/api/soccer/match.rb - About 3 hrs to fix

      Method update has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              def update(data, **opts)
          if data["sport_event"]
            update(data["sport_event"])
          end
          if data["sport_event_status"]
      Severity: Minor
      Found in lib/sportradar/api/soccer/match.rb - About 1 hr to fix

        Method clock_display has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

                def clock_display
          return unless @match_time
          if @stoppage_time && (@match_time == '45:00' || @match_time == '90:00') # stoppage time
            @match_time.split(':').first + ?' + '+' + @stoppage_time.split(':').first
          else
        Severity: Minor
        Found in lib/sportradar/api/soccer/match.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                def get_tournament_id(data, **opts)
          @tournament_id ||= if opts[:tournament]
            opts[:tournament].id
          elsif opts[:season]
            opts[:season].tournament_id
        Severity: Minor
        Found in lib/sportradar/api/soccer/match.rb and 1 other location - About 55 mins to fix
        lib/sportradar/api/soccer/team_group.rb on lines 27..39

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status