Sign upLogin

beneggett/sportradar-api

View on GitHub
Star
lib/sportradar/api/soccer/player.rb

Summary

Maintainability
C
1 day
Test Coverage

Method set_game_stats has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
Open

        def set_game_stats(data)
          @game_stats ||= {}

          @game_stats[:substituted_in] = data['substituted_in'] if data['substituted_in'].present?
          @game_stats[:substituted_out] = data['substituted_out'] if data['substituted_out'].present?
Severity: Minor
Found in lib/sportradar/api/soccer/player.rb - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

        def update(data, **opts)
          @id             = data['id']             if data['id']
          @league_group = opts[:league_group] || data['league_group'] || @league_group

          if data['player']
Severity: Minor
Found in lib/sportradar/api/soccer/player.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method set_game_stats has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def set_game_stats(data)
          @game_stats ||= {}

          @game_stats[:substituted_in] = data['substituted_in'] if data['substituted_in'].present?
          @game_stats[:substituted_out] = data['substituted_out'] if data['substituted_out'].present?
Severity: Minor
Found in lib/sportradar/api/soccer/player.rb - About 1 hr to fix

    Method update has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def update(data, **opts)
          @id             = data['id']             if data['id']
          @league_group = opts[:league_group] || data['league_group'] || @league_group

          if data['player']
    Severity: Minor
    Found in lib/sportradar/api/soccer/player.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status