Sign upLogin

bensaufley/code-words-api

View on GitHub
Star

Showing 16 of 16 total issues

File games-resource-test.js has 689 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';

const helper = require('../test-helper'),
      expect = helper.expect,
      sinon = helper.sinon,
Severity: Major
Found in test/requests/games-resource-test.js - About 1 day to fix

    File game-test.js has 481 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    'use strict';

const helper = require('../test-helper'),
      expect = helper.expect,
      sinon = helper.sinon,
    Severity: Minor
    Found in test/models/game-test.js - About 7 hrs to fix

      File players-resource-test.js has 267 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      'use strict';

const helper = require('../test-helper'),
      expect = helper.expect,
      sinon = helper.sinon,
      Severity: Minor
      Found in test/requests/players-resource-test.js - About 2 hrs to fix

        Function completeGame has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

          completeGame: (game) => {
    const turns = [],
          transmitters = game.players.filter((p) => p.role === 'transmitter').reduce((obj, p) => ({ ...obj, [p.team]: p }), {}),
          decoders = game.players.filter((p) => p.role === 'decoder').reduce((obj, p) => ({ ...obj, [p.team]: p }), {}),
          tiles = game.getDataValue('board'),
        Severity: Minor
        Found in test/support/game-helpers.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function completeGame has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          completeGame: (game) => {
    const turns = [],
          transmitters = game.players.filter((p) => p.role === 'transmitter').reduce((obj, p) => ({ ...obj, [p.team]: p }), {}),
          decoders = game.players.filter((p) => p.role === 'decoder').reduce((obj, p) => ({ ...obj, [p.team]: p }), {}),
          tiles = game.getDataValue('board'),
        Severity: Minor
        Found in test/support/game-helpers.js - About 1 hr to fix

          Function prepareGame has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            prepareGame: (attrs = {}) => {
    let aTransmitterUser, aDecoderUser, bTransmitterUser, bDecoderUser, aTransmitterPlayer, aDecoderPlayer, bTransmitterPlayer, bDecoderPlayer, game;
    return Promise.all([
      User.create({ username: 'transmitter-a', password: 'password' }),
      User.create({ username: 'decoder-a', password: 'password' }),
          Severity: Minor
          Found in test/support/game-helpers.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            }, {
  defaultScope: {
    where: { deletedAt: null }
  },
  sequelize: sequelizeInstance,
            Severity: Major
            Found in models/game.js and 1 other location - About 1 hr to fix
            models/player.js on lines 70..84

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 63.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            }, {
  defaultScope: {
    where: { deletedAt: null }
  },
  sequelize: sequelizeInstance,
            Severity: Major
            Found in models/player.js and 1 other location - About 1 hr to fix
            models/game.js on lines 195..209

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 63.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                      decoders = game.players.filter((p) => p.role === 'decoder').reduce((obj, p) => ({ ...obj, [p.team]: p }), {}),
            Severity: Minor
            Found in test/support/game-helpers.js and 1 other location - About 50 mins to fix
            test/support/game-helpers.js on lines 44..44

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 57.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                      transmitters = game.players.filter((p) => p.role === 'transmitter').reduce((obj, p) => ({ ...obj, [p.team]: p }), {}),
            Severity: Minor
            Found in test/support/game-helpers.js and 1 other location - About 50 mins to fix
            test/support/game-helpers.js on lines 45..45

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 57.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function setSecurePassword has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

            const setSecurePassword = (user, options) => {
  if (!user.password) return Promise.resolve(options);

  return new Promise((resolve, reject) => {
    bcrypt.genSalt(10, (err, salt) => {
            Severity: Minor
            Found in models/user.js - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getToken has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            const getToken = (req) => {
  // istanbul ignore if
  if (!req) return null;

  return (req.body && req.body.access_token) ||
            Severity: Minor
            Found in middleware/validate-request.js - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function cleanDatabase has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            const cleanDatabase = () => {
  return new Promise((resolve, reject) => {
    pg.connect(config.dbUrl, (err, client, done) => {
      if (err) return reject(err);
      resolve([client, done]);
            Severity: Minor
            Found in test/test-helper.js - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this function.
            Open

                  return Player.create({ userId: newPlayerUser.id, gameId });
            Severity: Major
            Found in resources/players.js - About 30 mins to fix

              Function nextTurn has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                nextTurn() {
    if (!this.activePlayerId) return Promise.reject(new Error('Game is not started'));
    if (this.completed()) return Promise.reject(new Error('Game is over'));

    const activePlayer = this.players.find((p) => p.id === this.activePlayerId);
              Severity: Minor
              Found in models/game.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function _playTurn has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              const _playTurn = (role, requiredBodyParams = [], turnFunc) => {
  return requireGame((req, res) => {
    let { user, params: { gameId } } = req;

    const turnFuncParams = requiredBodyParams.reduce((obj, key) => {
              Severity: Minor
              Found in resources/games.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language