Showing 12 of 16 total issues
File games-resource-test.js
has 689 lines of code (exceeds 250 allowed). Consider refactoring. Open
'use strict';
const helper = require('../test-helper'),
expect = helper.expect,
sinon = helper.sinon,
File game-test.js
has 481 lines of code (exceeds 250 allowed). Consider refactoring. Open
'use strict';
const helper = require('../test-helper'),
expect = helper.expect,
sinon = helper.sinon,
File players-resource-test.js
has 267 lines of code (exceeds 250 allowed). Consider refactoring. Open
'use strict';
const helper = require('../test-helper'),
expect = helper.expect,
sinon = helper.sinon,
Function completeGame
has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open
completeGame: (game) => {
const turns = [],
transmitters = game.players.filter((p) => p.role === 'transmitter').reduce((obj, p) => ({ ...obj, [p.team]: p }), {}),
decoders = game.players.filter((p) => p.role === 'decoder').reduce((obj, p) => ({ ...obj, [p.team]: p }), {}),
tiles = game.getDataValue('board'),
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function completeGame
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
completeGame: (game) => {
const turns = [],
transmitters = game.players.filter((p) => p.role === 'transmitter').reduce((obj, p) => ({ ...obj, [p.team]: p }), {}),
decoders = game.players.filter((p) => p.role === 'decoder').reduce((obj, p) => ({ ...obj, [p.team]: p }), {}),
tiles = game.getDataValue('board'),
Function prepareGame
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
prepareGame: (attrs = {}) => {
let aTransmitterUser, aDecoderUser, bTransmitterUser, bDecoderUser, aTransmitterPlayer, aDecoderPlayer, bTransmitterPlayer, bDecoderPlayer, game;
return Promise.all([
User.create({ username: 'transmitter-a', password: 'password' }),
User.create({ username: 'decoder-a', password: 'password' }),
Function setSecurePassword
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
const setSecurePassword = (user, options) => {
if (!user.password) return Promise.resolve(options);
return new Promise((resolve, reject) => {
bcrypt.genSalt(10, (err, salt) => {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getToken
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
const getToken = (req) => {
// istanbul ignore if
if (!req) return null;
return (req.body && req.body.access_token) ||
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function cleanDatabase
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
const cleanDatabase = () => {
return new Promise((resolve, reject) => {
pg.connect(config.dbUrl, (err, client, done) => {
if (err) return reject(err);
resolve([client, done]);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this function. Open
return Player.create({ userId: newPlayerUser.id, gameId });
Function nextTurn
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
nextTurn() {
if (!this.activePlayerId) return Promise.reject(new Error('Game is not started'));
if (this.completed()) return Promise.reject(new Error('Game is over'));
const activePlayer = this.players.find((p) => p.id === this.activePlayerId);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function _playTurn
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
const _playTurn = (role, requiredBodyParams = [], turnFunc) => {
return requireGame((req, res) => {
let { user, params: { gameId } } = req;
const turnFuncParams = requiredBodyParams.reduce((obj, key) => {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"