Sign upLogin

benvial/gyptis

View on GitHub
Star
src/gyptis/models/grating2d.py

Summary

Maintainability
C
1 day
Test Coverage

File grating2d.py has 324 lines of code (exceeds 250 allowed). Consider refactoring.
Open

#!/usr/bin/env python
# -*- coding: utf-8 -*-
# Author: Benjamin Vial
# This file is part of gyptis
# Version: 1.0.2
Severity: Minor
Found in src/gyptis/models/grating2d.py - About 3 hrs to fix

    Function diffraction_efficiencies has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

        def diffraction_efficiencies(
        self,
        N_order=0,
        cplx_effs=False,
        orders=False,
    Severity: Minor
    Found in src/gyptis/models/grating2d.py - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __init__ has 11 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __init__(
    Severity: Major
    Found in src/gyptis/models/grating2d.py - About 1 hr to fix

      Function plot_field has 10 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def plot_field(
      Severity: Major
      Found in src/gyptis/models/grating2d.py - About 1 hr to fix

        Function plot_geometry has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def plot_geometry(self, nper=1, ax=None, c="k", **kwargs):
        if ax is None:
            ax = plt.gca()
        domains = self.geometry.subdomains["surfaces"]
        scatt = [d for d in domains if d not in self.geometry.layers]
        Severity: Minor
        Found in src/gyptis/models/grating2d.py - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function diffraction_efficiencies has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def diffraction_efficiencies(
        Severity: Minor
        Found in src/gyptis/models/grating2d.py - About 35 mins to fix

          Function compute_absorption has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              def compute_absorption(self, subdomain_absorption=False):
        omega = self.source.pulsation
        doms_no_pml = [
            z for z in self.epsilon.keys() if z not in ["pml_bottom", "pml_top"]
        ]
          Severity: Minor
          Found in src/gyptis/models/grating2d.py - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function plot_field has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              def plot_field(
        self,
        nper=1,
        type="real",
        field="total",
          Severity: Minor
          Found in src/gyptis/models/grating2d.py - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status