Sign upLogin

benvial/gyptis

View on GitHub
Star
src/gyptis/models/grating3d.py

Summary

Maintainability
C
1 day
Test Coverage

Function diffraction_efficiencies has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

    def diffraction_efficiencies(
        self,
        N_d_order=0,
        cplx_effs=False,
        orders=False,
Severity: Minor
Found in src/gyptis/models/grating3d.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function compute_absorption has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    def compute_absorption(self, subdomain_absorption=False):
        P0 = (
            self.period[0]
            * self.period[1]
            * (epsilon_0 / mu_0) ** 0.5
Severity: Minor
Found in src/gyptis/models/grating3d.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function __init__ has 10 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __init__(
Severity: Major
Found in src/gyptis/models/grating3d.py - About 1 hr to fix

    Function diffraction_efficiencies has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def diffraction_efficiencies(
    Severity: Minor
    Found in src/gyptis/models/grating3d.py - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status