Sign upLogin

benvial/gyptis

View on GitHub
Star
src/gyptis/models/scattering3d.py

Summary

Maintainability
C
7 hrs
Test Coverage

File scattering3d.py has 251 lines of code (exceeds 250 allowed). Consider refactoring.
Open

#!/usr/bin/env python
# -*- coding: utf-8 -*-
# Author: Benjamin Vial
# This file is part of gyptis
# Version: 1.0.2
Severity: Minor
Found in src/gyptis/models/scattering3d.py - About 2 hrs to fix

    Function get_T_matrix_coeff has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        def get_T_matrix_coeff(
        self,
        p0,
        p1,
        source_type,
    Severity: Minor
    Found in src/gyptis/models/scattering3d.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __init__ has 11 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __init__(
    Severity: Major
    Found in src/gyptis/models/scattering3d.py - About 1 hr to fix

      Function get_T_matrix has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          def get_T_matrix(
        self,
        p_max,
        degree_source=None,
        component="transverse",
      Severity: Minor
      Found in src/gyptis/models/scattering3d.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function get_T_matrix_coeff has 8 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def get_T_matrix_coeff(
      Severity: Major
      Found in src/gyptis/models/scattering3d.py - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status