berict/Tapad

View on GitHub

Showing 231 of 426 total issues

Method intentSharedElement has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public void intentSharedElement(final Activity activity, final String targetName, final int start_element_id, final String transitionName, int delay) {
Severity: Minor
Found in app/src/main/java/com/bedrock/padder/helper/IntentHelper.java - About 35 mins to fix

    Method setPadColor has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        void setPadColor(int row, int column, final int color, int duration, int delay) {
    Severity: Minor
    Found in app/src/main/java/com/bedrock/padder/model/sound/Pad.java - About 35 mins to fix

      Method init has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public void init(PresetStoreAdapter.PresetViewHolder vh,
                           PresetStoreAdapter ad,
                           PresetStore ps,
                           Preferences prefs,
                           Activity a) {
      Severity: Minor
      Found in app/src/main/java/com/bedrock/padder/model/preset/store/Item.java - About 35 mins to fix

        Method intentWithExtra has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public void intentWithExtra(final Activity activity, String name, final String extraName, final String extra, int delay) {
        Severity: Minor
        Found in app/src/main/java/com/bedrock/padder/helper/IntentHelper.java - About 35 mins to fix

          Method intentWithExtra has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public void intentWithExtra(final Activity activity, String name, final String extraName, final int extra, int delay) {
          Severity: Minor
          Found in app/src/main/java/com/bedrock/padder/helper/IntentHelper.java - About 35 mins to fix

            Method intentShareText has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public void intentShareText(final Activity activity, String subject, String text, final String hint, int delay) {
            Severity: Minor
            Found in app/src/main/java/com/bedrock/padder/helper/IntentHelper.java - About 35 mins to fix

              Method intentFlagWithExtra has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public void intentFlagWithExtra(final Activity activity, String name, final String extraName, final String extra, int delay) {
              Severity: Minor
              Found in app/src/main/java/com/bedrock/padder/helper/IntentHelper.java - About 35 mins to fix

                Method scaleInOverShoot has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public void scaleInOverShoot(final int view_id, final int delay, final long duration, String handlerName, final Activity activity) {
                Severity: Minor
                Found in app/src/main/java/com/bedrock/padder/helper/AnimateHelper.java - About 35 mins to fix

                  Method unzip has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      public void unzip(String zipLocation, String targetLocation, String presetName, Activity activity, Runnable onFinish) {
                  Severity: Minor
                  Found in app/src/main/java/com/bedrock/padder/helper/FileHelper.java - About 35 mins to fix

                    Method scaleIn has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        public void scaleIn(final int id, final int delay, final long duration, String handlerName, Activity activity) {
                    Severity: Minor
                    Found in app/src/main/java/com/bedrock/padder/helper/AnimateHelper.java - About 35 mins to fix

                      Method fadeOut has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          public void fadeOut(final int id, final int delay, final long duration, View parentView, Activity activity) {
                      Severity: Minor
                      Found in app/src/main/java/com/bedrock/padder/helper/AnimateHelper.java - About 35 mins to fix

                        Method fadeIn has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            public void fadeIn(final int id, final int delay, final long duration, String handlerName, Activity activity) {
                        Severity: Minor
                        Found in app/src/main/java/com/bedrock/padder/helper/AnimateHelper.java - About 35 mins to fix

                          Method scaleOut has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              public void scaleOut(final int id, final int delay, final long duration, String handlerName, Activity activity) {
                          Severity: Minor
                          Found in app/src/main/java/com/bedrock/padder/helper/AnimateHelper.java - About 35 mins to fix

                            Method fadeOutInvisible has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                public void fadeOutInvisible(final int id, final int delay, final long duration, View parentView, Activity activity) {
                            Severity: Minor
                            Found in app/src/main/java/com/bedrock/padder/helper/AnimateHelper.java - About 35 mins to fix

                              Method fadeIn has 5 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                  public void fadeIn(final View view, final int delay, final long duration, String handlerName, Activity activity) {
                              Severity: Minor
                              Found in app/src/main/java/com/bedrock/padder/helper/AnimateHelper.java - About 35 mins to fix

                                Method doInBackground has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                                Open

                                        @Override
                                        protected Void doInBackground(Void... voids) {
                                            for (File presetFolder : presets) {
                                                if (fileHelper.isPresetMetadataAvailable(presetFolder.getName())) {
                                                    // check folder's presets

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Method readSync has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                                Open

                                    private Sync readSync(XmlPullParser parser) throws XmlPullParserException, IOException {
                                        parser.require(XmlPullParser.START_TAG, ns, "sync");
                                        Log.i(getClass().getSimpleName(), "readSync");
                                        Sync sync = new Sync();
                                
                                

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Method readTutorial has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                                Open

                                    private Tutorial readTutorial(XmlPullParser parser) throws XmlPullParserException, IOException {
                                        Tutorial tutorial = new Tutorial(tag, activity);
                                        Log.i(getClass().getSimpleName(), "readTutorial");
                                
                                        parser.require(XmlPullParser.START_TAG, ns, "tutorial");

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Method getBackgroundColor has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                                Open

                                    public static int getBackgroundColor(int id, Activity activity) {
                                        View view = activity.findViewById(id);
                                        Drawable drawable = view.getBackground();
                                        if (drawable instanceof ColorDrawable) {
                                            ColorDrawable colorDrawable = (ColorDrawable) drawable;
                                Severity: Minor
                                Found in app/src/main/java/com/bedrock/padder/helper/WindowHelper.java - About 35 mins to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Method validateAll has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                                Open

                                    private boolean validateAll() {
                                        switch (MODE_TAG) {
                                            case "song":
                                                if (validateEditText(songName) &
                                                        validateEditText(songArtist) &
                                Severity: Minor
                                Found in app/src/main/java/com/bedrock/padder/activity/FeedbackActivity.java - About 35 mins to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Severity
                                Category
                                Status
                                Source
                                Language