Sign upLogin

berict/Tapad

View on GitHub
Star

Showing 426 of 426 total issues

File AnimateHelper.java has 979 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package com.bedrock.padder.helper;

import android.animation.Animator;
import android.animation.AnimatorSet;
import android.animation.ObjectAnimator;
Severity: Major
Found in app/src/main/java/com/bedrock/padder/helper/AnimateHelper.java - About 2 days to fix

    File Item.java has 820 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    package com.bedrock.padder.model.preset.store;

import android.animation.Animator;
import android.app.Activity;
import android.app.Notification;
    Severity: Major
    Found in app/src/main/java/com/bedrock/padder/model/preset/store/Item.java - About 1 day to fix

      File MainActivity.java has 766 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      package com.bedrock.padder.activity;

import android.app.Activity;
import android.content.DialogInterface;
import android.content.Intent;
      Severity: Major
      Found in app/src/main/java/com/bedrock/padder/activity/MainActivity.java - About 1 day to fix

        AnimateHelper has 93 methods (exceeds 20 allowed). Consider refactoring.
        Open

        @TargetApi(14)
public class AnimateHelper {
    private WindowHelper window = new WindowHelper();

    static String TAG = "AnimateHelper";
        Severity: Major
        Found in app/src/main/java/com/bedrock/padder/helper/AnimateHelper.java - About 1 day to fix

          File WindowHelper.java has 656 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          package com.bedrock.padder.helper;

import android.app.Activity;
import android.app.ActivityManager;
import android.content.Context;
          Severity: Major
          Found in app/src/main/java/com/bedrock/padder/helper/WindowHelper.java - About 1 day to fix

            Method getExceptionalRunnable has 274 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private Runnable getExceptionalRunnable(String textId) {
        Runnable exceptionalRunnable;
        final Activity a = activity;
        final WindowHelper w = new WindowHelper();
            Severity: Major
            Found in app/src/main/java/com/bedrock/padder/adapter/ItemAdapter.java - About 1 day to fix

              Method draw has 246 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private void draw() {
        final PresetSchema presetSchema = getPresetSchema();
        final Preset preset = presetSchema.getPreset();

        // load preset image
              Severity: Major
              Found in app/src/main/java/com/bedrock/padder/model/preset/store/Item.java - About 1 day to fix

                File SoundHelper.java has 568 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                package com.bedrock.padder.helper;

import android.app.Activity;
import android.content.Intent;
import android.content.pm.ShortcutInfo;
                Severity: Major
                Found in app/src/main/java/com/bedrock/padder/helper/SoundHelper.java - About 1 day to fix

                  WindowHelper has 55 methods (exceeds 20 allowed). Consider refactoring.
                  Open

                  public class WindowHelper {

    public void setNavigationBar(int colorId, Activity activity) {
        if (Build.VERSION.SDK_INT >= 16) {
            if (colorId == R.color.transparent) {
                  Severity: Major
                  Found in app/src/main/java/com/bedrock/padder/helper/WindowHelper.java - About 7 hrs to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            switch (PAD_PATTERN) {
            case 1:
                // 4 side
                if (row - 1 > 0) {
                    // left available
                    Severity: Major
                    Found in app/src/main/java/com/bedrock/padder/model/sound/Pad.java and 1 other location - About 7 hrs to fix
                    app/src/main/java/com/bedrock/padder/model/sound/Pad.java on lines 279..332

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 476.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            switch (PAD_PATTERN) {
            case 1:
                // 4 side
                if (row - 1 > 0) {
                    // left available
                    Severity: Major
                    Found in app/src/main/java/com/bedrock/padder/model/sound/Pad.java and 1 other location - About 7 hrs to fix
                    app/src/main/java/com/bedrock/padder/model/sound/Pad.java on lines 155..208

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 476.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    MainActivity has 53 methods (exceeds 20 allowed). Consider refactoring.
                    Open

                    public class MainActivity
        extends AppCompatActivity
        implements AboutFragment.OnFragmentInteractionListener {

    public static final String TAG = "MainActivity";
                    Severity: Major
                    Found in app/src/main/java/com/bedrock/padder/activity/MainActivity.java - About 7 hrs to fix

                      File FeedbackActivity.java has 479 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      package com.bedrock.padder.activity;

import android.app.Activity;
import android.content.Intent;
import android.os.Build;
                      Severity: Minor
                      Found in app/src/main/java/com/bedrock/padder/activity/FeedbackActivity.java - About 7 hrs to fix

                        Method onCreate has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring.
                        Open

                            @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);
                        Severity: Minor
                        Found in app/src/main/java/com/bedrock/padder/activity/MainActivity.java - About 7 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Item has 50 methods (exceeds 20 allowed). Consider refactoring.
                        Open

                        public class Item {

    private static final transient String TAG = "Store.Item";

    private transient PresetStore presetStore = null;
                        Severity: Minor
                        Found in app/src/main/java/com/bedrock/padder/model/preset/store/Item.java - About 7 hrs to fix

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  if (view.getVisibility() == View.VISIBLE) {
            PowerManager powerManager = (PowerManager) activity.getSystemService(POWER_SERVICE);

            if (Build.VERSION.SDK_INT >= 21 && powerManager.isPowerSaveMode()) {
                // power save mode on
                          Severity: Major
                          Found in app/src/main/java/com/bedrock/padder/helper/AnimateHelper.java and 1 other location - About 6 hrs to fix
                          app/src/main/java/com/bedrock/padder/helper/AnimateHelper.java on lines 372..424

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 368.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  if (view.getVisibility() == View.VISIBLE) {
            PowerManager powerManager = (PowerManager) activity.getSystemService(POWER_SERVICE);

            if (Build.VERSION.SDK_INT >= 21 && powerManager.isPowerSaveMode()) {
                // power save mode on
                          Severity: Major
                          Found in app/src/main/java/com/bedrock/padder/helper/AnimateHelper.java and 1 other location - About 6 hrs to fix
                          app/src/main/java/com/bedrock/padder/helper/AnimateHelper.java on lines 314..366

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 368.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          File ItemAdapter.java has 411 lines of code (exceeds 250 allowed). Consider refactoring.
                          Open

                          package com.bedrock.padder.adapter;

import android.app.Activity;
import android.content.Context;
import android.support.annotation.NonNull;
                          Severity: Minor
                          Found in app/src/main/java/com/bedrock/padder/adapter/ItemAdapter.java - About 5 hrs to fix

                            Method setPadColor has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
                            Open

                                void setPadColor() {
        setPadColor(color);

        switch (PAD_PATTERN) {
            case 1:
                            Severity: Minor
                            Found in app/src/main/java/com/bedrock/padder/model/sound/Pad.java - About 5 hrs to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Identical blocks of code found in 2 locations. Consider refactoring.
                            Open

                                public void fadeIn(final int id, final int delay, final long duration, String handlerName, Activity activity) {
        final AlphaAnimation fadeIn = new AlphaAnimation(0.0f, 1.0f);
        final View view = activity.findViewById(id);
        view.setVisibility(View.INVISIBLE);
        PowerManager powerManager = (PowerManager) activity.getSystemService(POWER_SERVICE);
                            Severity: Major
                            Found in app/src/main/java/com/bedrock/padder/helper/AnimateHelper.java and 1 other location - About 5 hrs to fix
                            app/src/main/java/com/bedrock/padder/helper/AnimateHelper.java on lines 252..308

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 349.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Severity
                            Category
                            Status
                            Source
                            Language