Sign upLogin

berict/Tapad

View on GitHub
Star

Showing 231 of 426 total issues

Method setPadColor has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    void setPadColor(int row, int column, final int color, int duration) {
        if (row * column != 0) {
            final View pad = getViewFromId("btn" + column + row, activity);
            if (getBackgroundColor(pad) != getColor(color, activity) && getBackgroundColor(pad) != getColor(color, activity)) {
                // was not pressed
Severity: Minor
Found in app/src/main/java/com/bedrock/padder/model/sound/Pad.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method circularRevealinDP has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public void circularRevealinDP(int view,
                                   int centerX, int centerY,
                                   int startRad, int endRad, TimeInterpolator interpolator,
                                   int duration, int delay, Activity activity) {
Severity: Minor
Found in app/src/main/java/com/bedrock/padder/helper/AnimateHelper.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getBackgroundColor has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public static int getBackgroundColor(View view) {
        Drawable drawable = view.getBackground();
        if (drawable instanceof ColorDrawable) {
            ColorDrawable colorDrawable = (ColorDrawable) drawable;
            if (Build.VERSION.SDK_INT >= 11) {
Severity: Minor
Found in app/src/main/java/com/bedrock/padder/helper/WindowHelper.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method circularRevealAnimator has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public Animator circularRevealAnimator(int view,
                                           int centerX, int centerY,
                                           int startRad, int endRad, TimeInterpolator interpolator,
                                           int duration, int delay, Activity activity) {
Severity: Minor
Found in app/src/main/java/com/bedrock/padder/helper/AnimateHelper.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

                        return false;
Severity: Major
Found in app/src/main/java/com/bedrock/padder/activity/FeedbackActivity.java - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                        return true;
    Severity: Major
    Found in app/src/main/java/com/bedrock/padder/activity/FeedbackActivity.java - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                              return false;
      Severity: Major
      Found in app/src/main/java/com/bedrock/padder/activity/FeedbackActivity.java - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                                return false;
        Severity: Major
        Found in app/src/main/java/com/bedrock/padder/activity/FeedbackActivity.java - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                              return true;
          Severity: Major
          Found in app/src/main/java/com/bedrock/padder/activity/FeedbackActivity.java - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                                return true;
            Severity: Major
            Found in app/src/main/java/com/bedrock/padder/activity/FeedbackActivity.java - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                                      return false;
              Severity: Major
              Found in app/src/main/java/com/bedrock/padder/activity/FeedbackActivity.java - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                    return true;
                Severity: Major
                Found in app/src/main/java/com/bedrock/padder/activity/FeedbackActivity.java - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                          return false;
                  Severity: Major
                  Found in app/src/main/java/com/bedrock/padder/activity/FeedbackActivity.java - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                            return false;
                    Severity: Major
                    Found in app/src/main/java/com/bedrock/padder/activity/FeedbackActivity.java - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                              return false;
                      Severity: Major
                      Found in app/src/main/java/com/bedrock/padder/activity/FeedbackActivity.java - About 30 mins to fix

                        Method readHeadBpm has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                            private int readHeadBpm(XmlPullParser parser) throws XmlPullParserException, IOException {
        parser.require(XmlPullParser.START_TAG, ns, "head");
        Log.i(getClass().getSimpleName(), "readHeadBpm");
        int bpm = -1;
        while (parser.next() != XmlPullParser.END_TAG) {
                        Severity: Minor
                        Found in app/src/main/java/com/bedrock/padder/model/tutorial/TutorialXmlParser.java - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Method onRequestPermissionsResult has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                            @Override
    public void onRequestPermissionsResult(int requestCode, @NonNull String[] permissions, @NonNull int[] grantResults) {
        super.onRequestPermissionsResult(requestCode, permissions, grantResults);
        switch (requestCode) {
            case REQUEST_WRITE_STORAGE:
                        Severity: Minor
                        Found in app/src/main/java/com/bedrock/padder/activity/PresetStoreActivity.java - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Method readBody has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                            private ArrayList<Sync> readBody(XmlPullParser parser) throws XmlPullParserException, IOException {
        parser.require(XmlPullParser.START_TAG, ns, "body");
        Log.i(getClass().getSimpleName(), "readBody");
        ArrayList<Sync> syncList = new ArrayList<>();
        while (parser.next() != XmlPullParser.END_TAG) {
                        Severity: Minor
                        Found in app/src/main/java/com/bedrock/padder/model/tutorial/TutorialXmlParser.java - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Method setRecentColor has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public void setRecentColor(String title, int color, Activity activity) {
        if (Build.VERSION.SDK_INT >= 21) {
            if (title == null) {
                // Default app name
                title = activity.getResources().getString(R.string.app_name);
                        Severity: Minor
                        Found in app/src/main/java/com/bedrock/padder/helper/WindowHelper.java - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Method hasSamePad has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public boolean hasSamePad(Sync sync) {
        for (int i = 0; i < this.items.size(); i++) {
            for (int j = 0; j < sync.items.size(); j++) {
                if (this.items.get(i).equals(sync.items.get(j))) {
                    return true;
                        Severity: Minor
                        Found in app/src/main/java/com/bedrock/padder/model/tutorial/Sync.java - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Severity
                        Category
                        Status
                        Source
                        Language