Sign upLogin

berkshelf/ridley

View on GitHub
Star
lib/ridley/resources/cookbook_resource.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method upload has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def upload(path, options = {})
      options  = options.reverse_merge(validate: true, force: false, freeze: false)
      cookbook = Ridley::Chef::Cookbook.from_path(path)

      unless (existing = find(cookbook.cookbook_name, cookbook.version)).nil?
Severity: Minor
Found in lib/ridley/resources/cookbook_resource.rb - About 1 hr to fix

    Method upload has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def upload(path, options = {})
      options  = options.reverse_merge(validate: true, force: false, freeze: false)
      cookbook = Ridley::Chef::Cookbook.from_path(path)

      unless (existing = find(cookbook.cookbook_name, cookbook.version)).nil?
    Severity: Minor
    Found in lib/ridley/resources/cookbook_resource.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method find has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def find(object, version)
      chef_id = object.respond_to?(:chef_id) ? object.chef_id : object
      new(request(:get, "#{self.class.resource_path}/#{chef_id}/#{version}"))
    rescue AbortError => ex
      return nil if ex.cause.is_a?(Errors::HTTPNotFound)
    Severity: Minor
    Found in lib/ridley/resources/cookbook_resource.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status