Sign upLogin

bestmike007/appbase

View on GitHub
Star
lib/appbase/controllers/app_base_controller.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method add_query_stub has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def add_query_stub(model)
      m = model.name
      self.class_eval %-
        def query_#{AppBase.underscore m}
          query = #{m}.accessible_by(current_user)
Severity: Minor
Found in lib/appbase/controllers/app_base_controller.rb - About 1 hr to fix

    Method init_parameters has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

          def init_parameters
        parameters = @bound_method.parameters
        pre_init_parameters(parameters)
        
        need_params = false
    Severity: Minor
    Found in lib/appbase/controllers/app_base_controller.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method init has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

          def init
        init_parameters do |parameters, need_params|
          @requires = parameters.map{|p|":#{p[1]}"}
          @parameters = @auth ? ['current_user'] : []
          @requires.each { |p| @parameters << "params[#{p}]" }
    Severity: Minor
    Found in lib/appbase/controllers/app_base_controller.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status