Sign upLogin

bestmike007/log4rails

View on GitHub
Star
lib/log4r/outputter/emailoutputter.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method validate_smtp_params has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def validate_smtp_params(hash)
      ParameterParsers.each { |k, v|
        v ||= {}
        value = hash[k] || hash[k.to_s]
        value ||= v[:default]
Severity: Minor
Found in lib/log4r/outputter/emailoutputter.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method enable_starttls has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def enable_starttls(smtp)
        # >1.8.7 has smtp_tls built in, 1.8.6 requires smtp_tls
        if RUBY_VERSION < "1.8.7" then
          begin
            require 'rubygems'
Severity: Minor
Found in lib/log4r/outputter/emailoutputter.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method canonical_log has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def canonical_log(event)
      synch {
          @buff.push @formatfirst ? @formatter.format(event) : event
        send_mail if @buff.size >= @buffsize or @immediate[event.level]
      }
Severity: Minor
Found in lib/log4r/outputter/emailoutputter.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status