betagouv/service-national-universel

View on GitHub
admin/src/scenes/develop/AssetsPresentationPage.jsx

Summary

Maintainability
F
4 days
Test Coverage

Function AssetsPresentationPage has 729 lines of code (exceeds 200 allowed). Consider refactoring.
Open

export default function AssetsPresentationPage() {
  const [filter, setFilter] = useState("");
  useEffect(() => {
    const filterText = filter && filter.trim().length > 0 ? filter.trim().toLowerCase() : "";
    if (filterText && filterText.length > 0) {
Severity: Major
Found in admin/src/scenes/develop/AssetsPresentationPage.jsx - About 2 days to fix

    File AssetsPresentationPage.jsx has 896 lines of code (exceeds 700 allowed). Consider refactoring.
    Open

    /* eslint-disable prettier/prettier */
    /* ------------------------------------------------------
       Cette Page est générée automatiquement par le script /utils/generate-assets-presentation-page.js
       ------------------------------------------------------ */
    
    
    Severity: Major
    Found in admin/src/scenes/develop/AssetsPresentationPage.jsx - About 6 hrs to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

        useEffect(() => {
          const filterText = filter && filter.trim().length > 0 ? filter.trim().toLowerCase() : "";
          if (filterText && filterText.length > 0) {
            document.querySelectorAll("[data-name]").forEach((element) => {
              if (element.getAttribute("data-name").indexOf(filterText) >= 0) {
      Severity: Major
      Found in admin/src/scenes/develop/AssetsPresentationPage.jsx and 1 other location - About 3 hrs to fix
      app/src/scenes/develop/AssetsPresentationPage.jsx on lines 102..117

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 210.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status